Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensureScrollValueMonitoring in ReactEventEmitter should accept a mountAt argument #605

Closed
subtleGradient opened this issue Nov 25, 2013 · 4 comments
Closed

ensureScrollValueMonitoring in ReactEventEmitter should accept a mountAt argument #605

subtleGradient opened this issue Nov 25, 2013 · 4 comments
Labels
Component: DOM

Comments

@subtleGradient
Copy link
Contributor

listenAtTopLevel accepts a contentDocument.
All listeners are added to that contentDocument except for the ones registered in ensureScrollValueMonitoring which register on window.
@arr-ee
Copy link

arr-ee commented Jan 16, 2014

Correct me if I’m wrong, but 80d7d2d seems to fix that.

@sophiebits
Copy link
Collaborator

I'm not so sure. I think we need ViewportMetrics for each window object.

@syranide
Copy link
Contributor

Related #2271

@gaearon
Copy link
Collaborator

gaearon commented Mar 18, 2016

Since #6129 we no longer listen to scroll events except in IE8.
We also stop officially supporting IE8 in React 15.
As far as I can see effectively this means that this issue is no longer relevant.

Thank you for reporting, and please let me know if I’m wrong to close this one.

@gaearon gaearon closed this as completed Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DOM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@subtleGradient @sophiebits @zpao @arr-ee @gaearon @syranide