-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fast click to remove delay on mobile web browser #2753
Comments
If you just load the regular FastClick then that should fix the browser delay at the DOM event level, which the React event system sits on top. Right? |
@RickWong no. FastClick doesn't work with React because React has all faux events. I wish it did support it tho. Now we have to include a click helper mixin everywhere. Its kinda gross. |
Odd – I was under the impression that fastclick works properly with React. |
@spicyj other people have run into it not working. Asking around about it everyone has their own hacks around it. http://stackoverflow.com/questions/24335821/can-i-fastclick-reactjs-running-in-cordova |
I ended up using react-tap-event-plugin |
@iamstarkov how are you using react-tap-event-plugin to solve the problem? |
yep |
How are you using it? |
The same way as stated in readme of react-tap-event-plugin |
I added the library though and didn't see any noticeable change. I'm using the commonjs syntax to require and inject the plugin. Sent from my iPhone
|
It’s not enough to inject it, you alse need to use |
nvm. following this answer immediately made fastclick work for me. http://stackoverflow.com/a/30316754/1770280 I'm not sure whether all edge cases are covered but most of the problems I was facing were fixed by that few lines of code. |
Does the react-tap-event-plugin also work with desktop? (i.e., one solution to rule 'em all?) |
Most mobile browsers have already fixed this. https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away?hl=en Also, as per #436 (comment), we are probably going in the opposite direction and pulling the tap event plugin out of the core. |
On our two IOS 9.3 test ipads, doing
For this reason, we are still using fastclick.js with our react.js app (see http://stackoverflow.com/questions/24335821/can-i-fastclick-reactjs-running-in-cordova/30316754#30316754 ). fastclick only activates where necessary. |
fastClick cannot get along with |
Will be nice is react has this feature that improve responsiveness similar to FastClick by FT Labs.
The text was updated successfully, but these errors were encountered: