Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding better error message for missing mixin #2687

Closed
justin808 opened this issue Dec 9, 2014 · 1 comment
Closed

Adding better error message for missing mixin #2687

justin808 opened this issue Dec 9, 2014 · 1 comment

Comments

@justin808
Copy link

Can I add an informative message to:
https://github.com/facebook/react/blob/master/src/class/ReactClass.js#L430

in case that we try to mixin either nil, null, or {}

(basically, I'll submit a patch if maintainers think this is a good idea)
@sophiebits
Copy link
Collaborator

See #1302 and #1305 – we'd like to do this but last time it wasn't possible due to some mocking problems.

@sophiebits sophiebits mentioned this issue Dec 9, 2014
Closed
josephsavona added a commit that referenced this issue May 15, 2024
@josephsavona
Repro for scope with no declarations (already fixed on this stack)
d5eca2e 
Repro from T180504728 which reproduced internally and on playground, neither of 
which have #2687 yet. That PR (earlier in this stack) already fixes the issue, 
so i'm just adding the repro to help prevent regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sophiebits @justin808