You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Execute that and it goes boom, IE8 throws away all children of noscript after render and violently screams if you in any way try to add children afterwards.
Should you be mutating noscript? No, you shouldn't, but I imagine that reality is not quite as simple, where it could look something like:
<noscript>There are {count} items</noscript>
and there you have an error if count ever changes.
Practically though, noscript content is useless client-side and I see no reason why we shouldn't just discard any children passed to it client-side (for performance gains). If there are children left there from server-rendering, they will stay as-is until the noscript is removed from the DOM at a later time.
This could easily be done by adding a simple ReactDOMNoScript component that just returns noscript(this.props, null) if it's not for server-rendering. I could whip up a PR if you guys think it's a good idea? @zpao?
The text was updated successfully, but these errors were encountered:
Execute that and it goes boom, IE8 throws away all children of
noscript
after render and violently screams if you in any way try to add children afterwards.Should you be mutating
noscript
? No, you shouldn't, but I imagine that reality is not quite as simple, where it could look something like:and there you have an error if
count
ever changes.Practically though,
noscript
content is useless client-side and I see no reason why we shouldn't just discard any children passed to it client-side (for performance gains). If there are children left there from server-rendering, they will stay as-is until thenoscript
is removed from the DOM at a later time.This could easily be done by adding a simple
ReactDOMNoScript
component that just returnsnoscript(this.props, null)
if it's not for server-rendering. I could whip up a PR if you guys think it's a good idea? @zpao?The text was updated successfully, but these errors were encountered: