-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better event docs #171
Comments
Docs docs docs :) I know they're not fun to write but for developers coming to React, I think it should be assumed that they know nothing. Document everything. Is anyone actually working on this or is it something that the community will need to contribute? |
@BenQuinn we're trying to be good open-source stewards so it should be expected that we document everything rather than relying on contributions :) If we don't get a PR from the community soon I'll just go ahead and update them. |
Improve contrast for light mode
Coming out of https://groups.google.com/forum/?fromgroups#!topic/reactjs/2DVIcjDRVbo, it would be good to talk more about how events are handled and different patterns of use. We do a pretty good job of saying that we attach listeners at the top level and use delegation but it's obviously not clear enough about cleanup. We may also want to mention how to use normal event listeners if you really wanted.
The text was updated successfully, but these errors were encountered: