Missing UMD variant of react.profiling.min.js

[realityforge]

The 16.5.0 package released to unpkg currently has the production/profiling variant present for cjs builds but there is no equivalent for umd builds.

i.e. There is the file https://unpkg.com/[email protected]/cjs/react.profiling.min.js but there is no https://unpkg.com/[email protected]/umd/react.profiling.min.js

It would be great if a future release had the profiling variant packaged as umd as well.

Also thanks for the awesome framework!

[gaearon]

AFAIK it might have been a mistake to provide the profiling build of react because it doesn't actually differ from the production build.

Only ReactDOM (and ScheduleTracking if you use that) need to have a profiling mode.

@bvaughn Please correct if I'm wrong? We should fix it one way or another though.

[bvaughn]

I think cjs/react.profiling.min.js is an artifact of the way we were initially exposing the scheduling/tracing API through the SECRET object on React. We no longer do this for CJS builds so you're right that we can safely remove that from react.

That being said, we also don't have a react-dom production+profiling UMD variant because UMD profiling support seemed like an edge case. If we want to support it, we'll need to add a new UMD_PROFILING build type and plug it into the react and react-dom bundles (and probably add an entry point matching this naming convention to the schedule bundle to avoid confusion).

[realityforge]

Thanks for the clarification. We would be one of the edge cases that use UMD production profiling. Glad to see it make it in.

Thanks again!

[bvaughn]

👍