Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN] Remove ReactNativePropRegistry #12559

Merged
merged 1 commit into from
Apr 10, 2018
Merged

[RN] Remove ReactNativePropRegistry #12559

merged 1 commit into from
Apr 10, 2018

Conversation

sebmarkbage
Copy link
Collaborator

This has always been an unnecessary indirection to protect opaqueness, which hasn't really worked out.

This is not quite ready to land. I'm removing this upstream first.

@sebmarkbage
Remove ReactNativePropRegistry
a02155a 
This has always been an unnecessary indirection to protect opaqueness,
which hasn't really worked out.
@sebmarkbage sebmarkbage changed the title Remove ReactNativePropRegistry [RN] Remove ReactNativePropRegistry Apr 7, 2018
@sebmarkbage sebmarkbage mentioned this pull request Apr 7, 2018
Merged
bvaughn
bvaughn approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with the history of this module, but it looks like it should be easy to update Stylesheet and flattenStyle not to depend on it (or just to move it into RN and out of React)

@sebmarkbage
Copy link
Collaborator Author

It’s not easy to decouple but is fairly easy to delete with a breaking change.

@sebmarkbage sebmarkbage merged commit 933f882 into facebook:master Apr 10, 2018
This was referenced Apr 17, 2018
Closed
Closed
This was referenced Apr 19, 2018
Closed
Closed
Closed
Closed
rhagigi pushed a commit to rhagigi/react that referenced this pull request Apr 19, 2018
@sebmarkbage @rhagigi
Remove ReactNativePropRegistry (facebook#12559)
f82e3fe 
This has always been an unnecessary indirection to protect opaqueness,
which hasn't really worked out.
@jaramir jaramir mentioned this pull request Apr 20, 2018
Closed
@renovate renovate bot mentioned this pull request Apr 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

@sophiebits sophiebits Awaiting requested review from sophiebits

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebmarkbage @bvaughn @facebook-github-bot