-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop document.createElement in tests #1250
Labels
Comments
@sebmarkbage has a codmod coming that touches a bunch of these, so don't jump in quite yet. |
Okay, keep me posted. I'll manually fix any callsites that slip through the codemod. |
Codemod in. He wasn't actually fixing them, just touching code around them so would have been merge hell. |
Is it safe to try to get those patched now? |
It should be. Feel free to take it on. Let me know if you have any questions! |
jimfb
added a commit
to jimfb/react
that referenced
this issue
Nov 25, 2014
…t where container was not subsequently utilized. Fixes facebook#1250
This was referenced Sep 16, 2021
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced Nov 27, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a ton of places that do
We should just be doing
This isn't an exciting task, but gets you exposed to lots of tests which can help with understanding react core better. cc @kmeht
The text was updated successfully, but these errors were encountered: