value|defaultValue={Symbol|Function} should be ignored, not stringified

[gaearon]

Regression in master from #11534.
Found it thanks to the attribute fixture snapshots.

[nhunzaker]

Just for clarity: This is the correct behavior for Symbols:

With my change, value and defaultValue never pass through the property sanitation layer. React tries to stringify symbols, which throws an error, and functions get turned into "function () {}".

[gaearon]

Now that I looked at this again, the update codepath was already broken. This just made the initial code path match it. So this is actually an improvement. We should still get #11741 to completion to have consistent sane behavior, but IMO this is not as urgent as I thought at first.

[kanlanc]

Is it resolved or can I start working on it?

Sorry new to open source

[gaearon]

I think the issue still exists, it’s just more consistent now

[kanlanc]

just for reference how do you call dibs on a bug

[gaearon]

You got it

[t4deu]

Ping @highskillzz, do you still on this issue?

If not, I will take it, ok @gaearon 😉

[kanlanc]

Sure

[raunofreiberg]

What's the status on this one? It doesn't seem like this has been resolved since there are no warnings on assigning symbols or functions to the defaultValue prop. Even found a few TODO-s in the ReactDOMInput test.

[gaearon]

Feel free to grab it. I don't know if it's fixed or not but it's worth checking.

[krrishdholakia]

@gaearon is this still open? if so, how do i claim it?

[philipp-spiess]

@krrishdholakia Yes this is still up for grabs if it is not already fixed! Feel free to start looking into it and reach out if you have any issues along the way. 😊

[raunofreiberg]

I checked earlier and I might be wrong but I'm quite sure this was fixed earlier by @nhunzaker

// Same goes for the `value` prop
return (
      <div>
        <input defaultValue={Symbol("test")} />
        <input defaultValue={() => {}} />
      </div>
);

produces

Which indicates that both symbols and functions are not stringified? I've still went ahead and added warnings for the defaultValue prop in #13360. Maybe useful.

[raunofreiberg]

Although, textarea seems to behave differently - not sure if intentionally or not.

function App() {
  return (
    <div>
      <textarea defaultValue={() => {}} />
      <textarea value={() => {}} />
      <textarea value={Symbol("test")} />
    </div>
  );
}

Both functions get stringified and appended as text into the textarea itself. The symbol itself crashes the application with a TypeError: Cannot convert a Symbol value to a string

For reproducing: https://codesandbox.io/s/pj40nrp5px

[philipp-spiess]

@raunofreiberg Thanks for looking into that! I agree that textarea should behave the same 👍

[raunofreiberg]

This looks perfect now. Thank you very much 🙂 If you want a follow-up task, you could work on the same fix for elements.

@philipp-spiess Do you mean working on the select tag 🙂? If so, I'd be happy to investigate further on that as well.

[chandanbauri]

Hi @gaearon ,
Could you please assign issue to me I'm excited to know if this is going to be my first contribution to react .

[kethesainikhil]

Hi @gaearon,
I am interested to take up this issue and I want work on it could you please assign me this and also I wanted you to Help me to contribute for this I am ready to learn and I am an intermediate coder in react

[koyuncuoglum95]

Hey @gaearon, I'd love to contribute this project. I'm here for the first time.

[Mule-ME]

Hey @gaearon, I would love to contribute this project. it's my first time to be here, I am an intermediate coder in react

[its-kunal]

Hey @gaearon, I am interested in this issue and want to contribute.

[sykalerio]

Hi there,

My name is [Elpida Syka Lerioti] and I'm interested in helping out with this issue. I've been studying testing and I think this would be a great opportunity for me to apply my skills and learn more about React.

I've read through the issue and I think I have a good understanding of the problem and the proposed solution. However, I'm new to the React project and I would appreciate any guidance or help you could give me to get started with testing.

Thanks for your time and I look forward to working with you!

Best regards,
Elpida Syka Lerioti

[MengLinMaker]

@sykalerio I think this was solved in #22841

A test codesandbox seem to confirm that the stringified behaviour is fixed.

I'm in the same boat, trying to contribute for the first time. I don't know why this issue isn't closed. Maybe I misunderstood the situation.

Can't seem to locate the test file though.

[MengLinMaker]

@gaearon, should this issue be closed?

[Vishrut19]

Is this issue still Open?

[bhanu567]

hey @gaearon is this issue still open ??

[theQuery]

Should this be closed or is there still some unexpected behavior occurring with this? 🤔

[NIKHILNAIR21]

is this issue is still open? @gaearon

[Tabhi109]

@gaearon Is this issue still open , Please assign it to me

[ValeriaHoody]

Hey, is this issue still open, interested to work on it.

[SouSingh]

Is it still open or closed? I would like to work on it

[DerickT02]

Is this still open?

[IshadP]

Is the issue still open? I am interested to work on it

[shobhnaawasthi]

Does this issue still persist? I am interested to work on it

[AmKreta]

@gaearon is this still open ? I have found a solution and want to make a pr !

[yogesh10-r]

Hi @gaearon !
is this still open? I'd like to contribute...

[mishchief]

For everyone coming here as per #11734 (comment)

This issue has been fixed...

[sankshit]

@gaearon It would be helpful if you guys can close this issue

[ScriptShah]

Hello , I'm here for the first time and would like to contribute this project.

[chiragmetaliya]

Hello, I believe I could contribute to this project. Can someone please clarify whether the issue is closed? I'm here for first time and it seems from previous thread comments that this issue is already closed.

[mishchief]

Hello, I believe I could contribute to this project. Can someone please clarify whether the issue is closed? I'm here for first time and it seems from previous thread comments that this issue is already closed.

Read the thread this is not an issue anymore and needs to be closed...

[AliSinaYOusofi]

how come this is not closed yet !

[Tayyabbutt1133]

I think the issue still exists, it’s just more consistent now

@gaearon is the bug is still there ? If yes, can I work on this ?

[WajahatKanju]

@gaearon if the bug is not there please close the issue. Other I am interested in working on it.

[frozenfrank]

I think it's hilarious that this:

1. Was created 7 years ago
2. is one of only two issues marked as "good first issues,"
3. is already resolved,
4. attracts a lot of attention from people requesting to have the issue assigned to them (but no one seems interested in just proposing a PR), AND
5. is still open.

This shows poor repo management.

[rahul3002]

Hi! I'm interested in working on this task. It seems straightforward, so I’ll give it a try and keep you updated on my progress. Thanks!