-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release a tool for statistical perf analysis (a replacement for ReactPerf) #11326
Comments
For exclusive and inclusive tables it might make sense to build something on top of Performance Observer API exposed by the browsers. This uses the high precision timings that we emit via our integration with User Timing API. In fact @wwwillchen already created a proof of concept a while ago: facebook/react-devtools#801. It would be great if someone could take it, polish, and turn into an npm module. The "wasted" table is more complicated and I'd rather not get into it until we figure out the async story in Fiber. It's not clear to me how it should work in async mode, and I'd rather not invest effort into it now if it will break later anyway. |
Hey! Can I work on this? I could take a look at @wwwillchen's work and then turn it into a usable npm module. |
Totes! |
Seems like @bvaughn's upcoming DevTools Profiler should help with this. |
That sounds super interesting. Is there a place where the progress can be followed? |
Do you want to request a feature or report a bug?
A feature
What is the current behavior?
N/A
What is the expected behavior?
It's great that React 16 integrates with the timeline in browsers dev tools and that is very helpful in cases where you are trying to fix the performance of a specific thing. However I do miss the perf tool from previous versions and could not find any issue tracking a re-implementation of such a tool.
What was great in the perf tool that is not covered as well with timeline integration?
Basically the wasted, exclusive and inclusive tables. The DOM table I feel is much better represented by the timeline integration.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
16, yes the perf addon in 15 was good.
The text was updated successfully, but these errors were encountered: