Skip to content

Commit

Permalink
Update ReactUpdates-test (#28061)
Browse files Browse the repository at this point in the history
## Overview

These tests are important for `ReactDOM.render`, so instead of just
re-writing them to `createRoot` and losing coverage:
- Moved the `.render` tests to `ReactLegacyUpdates`
- Re-wrote the tests in `ReactUpdates` to use `createRoot`
- Remove `unstable_batchedUpdates` from `ReactUpdates`

In a future PR, when I flag `batchedUpdates` with a Noop, I can add the
gate to just the tests in `ReactLegacyUpdates`.

DiffTrain build for commit 8bb6ee1.
  • Loading branch information
rickhanlonii committed Jan 25, 2024
1 parent 9f71904 commit f158e17
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25572,7 +25572,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-canary-5420c4ea0-20240124";
var ReactVersion = "18.3.0-canary-8bb6ee1d3-20240125";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9131,7 +9131,7 @@ var devToolsConfig$jscomp$inline_1031 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-5420c4ea0-20240124",
version: "18.3.0-canary-8bb6ee1d3-20240125",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1207 = {
Expand Down Expand Up @@ -9162,7 +9162,7 @@ var internals$jscomp$inline_1207 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-5420c4ea0-20240124"
reconcilerVersion: "18.3.0-canary-8bb6ee1d3-20240125"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1208 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9559,7 +9559,7 @@ var devToolsConfig$jscomp$inline_1073 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-5420c4ea0-20240124",
version: "18.3.0-canary-8bb6ee1d3-20240125",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1248 = {
Expand Down Expand Up @@ -9590,7 +9590,7 @@ var internals$jscomp$inline_1248 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-5420c4ea0-20240124"
reconcilerVersion: "18.3.0-canary-8bb6ee1d3-20240125"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1249 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "18.3.0-canary-5420c4ea0-20240124";
var ReactVersion = "18.3.0-canary-8bb6ee1d3-20240125";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -539,4 +539,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-5420c4ea0-20240124";
exports.version = "18.3.0-canary-8bb6ee1d3-20240125";
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-5420c4ea0-20240124";
exports.version = "18.3.0-canary-8bb6ee1d3-20240125";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5420c4ea08a4ccf06b04f0c0abdf1f5e8d84223a
8bb6ee1d33ca6c7e34342bc4b17aac0449ab6899

0 comments on commit f158e17

Please sign in to comment.