Replaced === check with Object.is() to support values like NaN (#16934)

facebook · Sep 27, 2019 · d427866 · d427866
1 parent d1121c0
commit d427866
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/packages/react-devtools-shared/src/__tests__/useEditableValue-test.js b/packages/react-devtools-shared/src/__tests__/useEditableValue-test.js
@@ -23,6 +23,24 @@ describe('useEditableValue', () => {
     useEditableValue = require('../devtools/views/hooks').useEditableValue;
   });
 
+  it('should not cause a loop with values like NaN', () => {
+    let state;
+
+    function Example({value = NaN}) {
+      const tuple = useEditableValue(value);
+      state = tuple[0];
+      return null;
+    }
+
+    const container = document.createElement('div');
+    ReactDOM.render(<Example />, container);
+    expect(state.editableValue).toEqual('NaN');
+    expect(state.externalValue).toEqual(NaN);
+    expect(state.parsedValue).toEqual(NaN);
+    expect(state.hasPendingChanges).toBe(false);
+    expect(state.isValid).toBe(true);
+  });
+
   it('should override editable state when external props are updated', () => {
     let state;
 

diff --git a/packages/react-devtools-shared/src/devtools/views/hooks.js b/packages/react-devtools-shared/src/devtools/views/hooks.js
@@ -87,8 +87,7 @@ export function useEditableValue(
     isValid: true,
     parsedValue: externalValue,
   });
-
-  if (state.externalValue !== externalValue) {
+  if (!Object.is(state.externalValue, externalValue)) {
     if (!state.hasPendingChanges) {
       dispatch({
         type: 'RESET',