Fix failing async tests in Node 10

Dunno why they happened to work in Node 8 but whatever. Tested on both.
facebook · Oct 20, 2018 · b753f76 · b753f76
1 parent d37f595
commit b753f76
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactServerRenderingHydration-test.js b/packages/react-dom/src/__tests__/ReactServerRenderingHydration-test.js
@@ -444,20 +444,16 @@ describe('ReactDOMServerHydration', () => {
   });
 
   it('should be able to use lazy components after hydrating', async () => {
-    async function fakeImport(result) {
-      return {default: result};
-    }
-
     const Lazy = React.lazy(
       () =>
         new Promise(resolve => {
           setTimeout(
             () =>
-              resolve(
-                fakeImport(function World() {
+              resolve({
+                default: function World() {
                   return 'world';
-                }),
-              ),
+                },
+              }),
             1000,
           );
         }),
@@ -491,7 +487,7 @@ describe('ReactDOMServerHydration', () => {
     expect(element.textContent).toBe('Hello loading');
 
     jest.runAllTimers();
-    await Lazy;
+    await Promise.resolve();
     expect(element.textContent).toBe('Hello world');
   });
 });
diff --git a/packages/react-reconciler/src/__tests__/ReactIncrementalPerf-test.internal.js b/packages/react-reconciler/src/__tests__/ReactIncrementalPerf-test.internal.js
@@ -573,7 +573,7 @@ describe('ReactDebugFiberPerf', () => {
       return <span />;
     }
 
-    async function fakeImport(result) {
+    function fakeImport(result) {
       return {default: result};
     }
 
@@ -600,7 +600,8 @@ describe('ReactDebugFiberPerf', () => {
         return <div />;
       }),
     );
-    await LazyFoo;
+
+    await Promise.resolve();
 
     ReactNoop.render(
       <Parent>

diff --git a/packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js b/packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js
@@ -319,7 +319,7 @@ describe('ReactLazy', () => {
       return fakeImport(Foo);
     });
 
-    const LazyForwardRef = lazy(async () => {
+    const LazyForwardRef = lazy(() => {
       class Bar extends React.Component {
         render() {
           return <Text text="Bar" />;