From 8cc23c8722d04c17434ae7bd66316661cfdec20f Mon Sep 17 00:00:00 2001
From: Josh Story
Date: Thu, 23 Mar 2023 09:00:09 -0700
Subject: [PATCH] add some more tests
---
.../src/__tests__/ReactDOMFloat-test.js | 183 +++++++++++++++++-
1 file changed, 182 insertions(+), 1 deletion(-)
diff --git a/packages/react-dom/src/__tests__/ReactDOMFloat-test.js b/packages/react-dom/src/__tests__/ReactDOMFloat-test.js
index c83451bd4a68f..45d7836683114 100644
--- a/packages/react-dom/src/__tests__/ReactDOMFloat-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMFloat-test.js
@@ -2771,7 +2771,8 @@ body {
]);
});
- fit('can delay commit until css resources error', async () => {
+ xit('can delay commit until css resources error', async () => {
+ // TODO: This test fails and crashes jest. need to figure out why before unskipping.
const root = ReactDOMClient.createRoot(container);
expect(getMeaningfulChildren(container)).toBe(undefined);
React.startTransition(() => {
@@ -2835,6 +2836,186 @@ body {
]);
});
+ it('assumes stylesheets that load in the shell loaded already', async () => {
+ await actIntoEmptyDocument(() => {
+ renderToPipeableStream(
+
+
+
+ hello
+
+ ,
+ ).pipe(writable);
+ });
+
+ let root;
+ React.startTransition(() => {
+ root = ReactDOMClient.hydrateRoot(
+ document,
+
+
+
+ hello
+
+ ,
+ );
+ });
+ await waitForAll([]);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+ hello
+ ,
+ );
+
+ React.startTransition(() => {
+ root.render(
+
+
+
+ hello2
+
+ ,
+ );
+ });
+ await waitForAll([]);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+ hello2
+ ,
+ );
+
+ React.startTransition(() => {
+ root.render(
+
+
+
+ hello3
+
+
+ ,
+ );
+ });
+ await waitForAll([]);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+
+ hello2
+ ,
+ );
+
+ loadPreloads();
+ assertLog(['load preload: bar']);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+
+
+ hello2
+ ,
+ );
+
+ loadStylesheets(['bar']);
+ assertLog(['load stylesheet: bar']);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+
+
+ hello3
+ ,
+ );
+ });
+
+ it('can interrupt a suspended commit with a new update', async () => {
+ function App({children}) {
+ return (
+
+ {children}
+
+ );
+ }
+ const root = ReactDOMClient.createRoot(document);
+ root.render();
+ React.startTransition(() => {
+ root.render(
+
+ hello
+
+ ,
+ );
+ });
+ await waitForAll([]);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+
+ ,
+ );
+
+ root.render(
+
+ hello2
+ {null}
+
+ ,
+ );
+ await waitForAll([]);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+
+
+ hello2
+ ,
+ );
+
+ loadPreloads(['foo']);
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+
+
+
+ hello2
+ ,
+ );
+
+ loadStylesheets(['foo']);
+ // Even though the foo stylesheet was still inserted as part of the suspense sequence of the first
+ // commit it does not actually perform the commit because it was cancelled when the higher priority
+ // update was processed.
+ expect(getMeaningfulChildren(document)).toEqual(
+
+
+
+
+
+
+
+ hello2
+ ,
+ );
+ });
+
describe('ReactDOM.prefetchDNS(href)', () => {
it('creates a dns-prefetch resource when called', async () => {
function App({url}) {