Ship diffInCommitPhase (#27409)

Performance tests at Meta showed neutral results.
facebook · Sep 23, 2023 · 7f62018 · 7f62018
1 parent d9e00f7
commit 7f62018
Show file tree

Hide file tree

Showing 21 changed files with 53 additions and 686 deletions.
diff --git a/packages/react-art/src/ReactFiberConfigART.js b/packages/react-art/src/ReactFiberConfigART.js
@@ -15,10 +15,8 @@ import {DefaultEventPriority} from 'react-reconciler/src/ReactEventPriorities';
 const pooledTransform = new Transform();
 
 const NO_CONTEXT = {};
-const UPDATE_SIGNAL = {};
 if (__DEV__) {
   Object.freeze(NO_CONTEXT);
-  Object.freeze(UPDATE_SIGNAL);
 }
 
 /** Helper Methods */
@@ -312,10 +310,6 @@ export function prepareForCommit() {
   return null;
 }
 
-export function prepareUpdate(domElement, type, oldProps, newProps) {
-  return UPDATE_SIGNAL;
-}
-
 export function resetAfterCommit() {
   // Noop
 }

diff --git a/packages/react-dom-bindings/src/client/CSSPropertyOperations.js b/packages/react-dom-bindings/src/client/CSSPropertyOperations.js
@@ -11,7 +11,6 @@ import hyphenateStyleName from '../shared/hyphenateStyleName';
 import warnValidStyle from '../shared/warnValidStyle';
 import isUnitlessNumber from '../shared/isUnitlessNumber';
 import {checkCSSPropertyStringCoercion} from 'shared/CheckStringCoercion';
-import {diffInCommitPhase} from 'shared/ReactFeatureFlags';
 
 /**
  * Operations for dealing with CSS properties.
@@ -126,7 +125,7 @@ export function setValueForStyles(node, styles, prevStyles) {
 
   const style = node.style;
 
-  if (diffInCommitPhase && prevStyles != null) {
+  if (prevStyles != null) {
     if (__DEV__) {
       validateShorthandPropertyCollisionInDev(prevStyles, styles);
     }
@@ -200,10 +199,7 @@ function expandShorthandMap(styles) {
  *   {font: 'foo', fontVariant: 'bar'} -> {font: 'foo'}
  *   becomes .style.fontVariant = ''
  */
-export function validateShorthandPropertyCollisionInDev(
-  prevStyles,
-  nextStyles,
-) {
+function validateShorthandPropertyCollisionInDev(prevStyles, nextStyles) {
   if (__DEV__) {
     if (!nextStyles) {
       return;