Fixed a StyleEditor variable resolution regression

facebook · Aug 27, 2019 · 7153dd5 · 7153dd5
1 parent 33d439f
commit 7153dd5
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...ages/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/StyleEditor.js b/...ages/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/StyleEditor.js
@@ -184,7 +184,7 @@ function Row({
   const validateAndSetLocalValue = newValue => {
     let isValid = false;
     try {
-      JSON.parse(sanitizeForParse(value));
+      JSON.parse(sanitizeForParse(newValue));
       isValid = true;
     } catch (error) {}
 
@@ -203,7 +203,7 @@ function Row({
   };
 
   const submitValueChange = () => {
-    if (isValueValid) {
+    if (isAttributeValid && isValueValid) {
       const parsedLocalValue = JSON.parse(sanitizeForParse(localValue));
       if (value !== parsedLocalValue) {
         changeValue(attribute, parsedLocalValue);
@@ -212,8 +212,10 @@ function Row({
   };
 
   const submitAttributeChange = () => {
-    if (isAttributeValid && attribute !== localAttribute) {
-      changeAttribute(attribute, localAttribute, value);
+    if (isAttributeValid && isValueValid) {
+      if (attribute !== localAttribute) {
+        changeAttribute(attribute, localAttribute, value);
+      }
     }
   };