[react-events] Ensure screen reader virtual clicks support preventDef…

…ault (#16600)
facebook · Aug 28, 2019 · 34aaec6 · 34aaec6
1 parent 01fb68b
commit 34aaec6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/react-events/src/dom/Press.js b/packages/react-events/src/dom/Press.js
@@ -635,6 +635,11 @@ const pressResponderImpl = {
         if (isFunction(onPress) && isScreenReaderVirtualClick(nativeEvent)) {
           state.pointerType = 'keyboard';
           state.pressTarget = event.responderTarget;
+          const preventDefault = props.preventDefault;
+
+          if (preventDefault !== false) {
+            nativeEvent.preventDefault();
+          }
           dispatchEvent(event, onPress, context, state, 'press', DiscreteEvent);
         }
         break;

diff --git a/packages/react-events/src/dom/__tests__/Press-test.internal.js b/packages/react-events/src/dom/__tests__/Press-test.internal.js
@@ -423,7 +423,9 @@ describe.each(environmentTable)('Press responder', hasPointerEvents => {
 
     it('is called once after virtual screen reader "click" event', () => {
       const target = createEventTarget(ref.current);
-      target.virtualclick();
+      const preventDefault = jest.fn();
+      target.virtualclick({preventDefault});
+      expect(preventDefault).toBeCalled();
       expect(onPress).toHaveBeenCalledTimes(1);
       expect(onPress).toHaveBeenCalledWith(
         expect.objectContaining({