Remove concurrent apis from stable (#17088)

* Tests run in experimental mode by default For local development, you usually want experiments enabled. Unless the release channel is set with an environment variable, tests will run with __EXPERIMENTAL__ set to `true`. * Remove concurrent APIs from stable builds Those who want to try concurrent mode should use the experimental builds instead. I've left the `unstable_` prefixed APIs in the Facebook build so we can continue experimenting with them internally without blessing them for widespread use. * Turn on SSR flags in experimental build * Remove prefixed concurrent APIs from www build Instead we'll use the experimental builds when syncing to www. * Remove "canary" from internal React version string
facebook · Oct 15, 2019 · 30c5daf · 30c5daf
1 parent 4cb399a
commit 30c5daf
Show file tree

Hide file tree

Showing 33 changed files with 1,946 additions and 2,198 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -98,7 +98,10 @@ jobs:
       - checkout
       - *restore_yarn_cache
       - *run_yarn
-      - run: yarn test --maxWorkers=2
+      - run:
+          environment:
+            RELEASE_CHANNEL: stable
+          command: yarn test --maxWorkers=2
 
   test_source_experimental:
     docker: *docker
@@ -120,7 +123,10 @@ jobs:
       - checkout
       - *restore_yarn_cache
       - *run_yarn
-      - run: yarn test-persistent --maxWorkers=2
+      - run:
+          environment:
+            RELEASE_CHANNEL: stable
+          command: yarn test-persistent --maxWorkers=2
 
   test_source_prod:
     docker: *docker
@@ -130,7 +136,10 @@ jobs:
       - checkout
       - *restore_yarn_cache
       - *run_yarn
-      - run: yarn test-prod --maxWorkers=2
+      - run:
+          environment:
+            RELEASE_CHANNEL: stable
+          command: yarn test-prod --maxWorkers=2
 
   build:
     docker: *docker
@@ -217,7 +226,23 @@ jobs:
       - attach_workspace: *attach_workspace
       - *restore_yarn_cache
       - *run_yarn
-      - run: yarn test-build --maxWorkers=2
+      - run:
+          environment:
+            RELEASE_CHANNEL: stable
+          command: yarn test-build --maxWorkers=2
+
+  test_build_experimental:
+    docker: *docker
+    environment: *environment
+    steps:
+      - checkout
+      - attach_workspace: *attach_workspace
+      - *restore_yarn_cache
+      - *run_yarn
+      - run:
+          environment:
+            RELEASE_CHANNEL: experimental
+          command: yarn test-build --maxWorkers=2
 
   test_build_devtools:
     docker: *docker
@@ -227,7 +252,10 @@ jobs:
       - attach_workspace: *attach_workspace
       - *restore_yarn_cache
       - *run_yarn
-      - run: yarn test-build-devtools --maxWorkers=2
+      - run:
+          environment:
+            RELEASE_CHANNEL: stable
+          command: yarn test-build --maxWorkers=2
 
   test_dom_fixtures:
     docker: *docker
@@ -238,6 +266,8 @@ jobs:
       - *restore_yarn_cache
       - run:
           name: Run DOM fixture tests
+          environment:
+            RELEASE_CHANNEL: stable
           command: |
             cd fixtures/dom
             yarn --frozen-lockfile
@@ -265,7 +295,23 @@ jobs:
       - attach_workspace: *attach_workspace
       - *restore_yarn_cache
       - *run_yarn
-      - run: yarn test-build-prod --maxWorkers=2
+      - run:
+          environment:
+            RELEASE_CHANNEL: stable
+          command: yarn test-build-prod --maxWorkers=2
+
+  test_build_prod_experimental:
+    docker: *docker
+    environment: *environment
+    steps:
+      - checkout
+      - attach_workspace: *attach_workspace
+      - *restore_yarn_cache
+      - *run_yarn
+      - run:
+          environment:
+            RELEASE_CHANNEL: experimental
+          command: yarn test-build-prod --maxWorkers=2
 
 workflows:
   version: 2
@@ -324,6 +370,12 @@ workflows:
       - process_artifacts_experimental:
           requires:
             - build_experimental
+      - test_build_experimental:
+          requires:
+            - build_experimental
+      - test_build_prod_experimental:
+          requires:
+            - build_experimental
 
   fuzz_tests:
     triggers:

diff --git a/fixtures/dom/src/__tests__/wrong-act-test.js b/fixtures/dom/src/__tests__/wrong-act-test.js
@@ -17,6 +17,7 @@ let TestRenderer;
 let ARTTest;
 
 global.__DEV__ = process.env.NODE_ENV !== 'production';
+global.__EXPERIMENTAL__ = process.env.RELEASE_CHANNEL === 'experimental';
 
 expect.extend(require('../toWarnDev'));
 
@@ -176,19 +177,21 @@ it("doesn't warn if you use nested acts from different renderers", () => {
   });
 });
 
-it('warns when using createRoot() + .render', () => {
-  const root = ReactDOM.unstable_createRoot(document.createElement('div'));
-  expect(() => {
-    TestRenderer.act(() => {
-      root.render(<App />);
-    });
-  }).toWarnDev(
-    [
-      'In Concurrent or Sync modes, the "scheduler" module needs to be mocked',
-      "It looks like you're using the wrong act()",
-    ],
-    {
-      withoutStack: true,
-    }
-  );
-});
+if (__EXPERIMENTAL__) {
+  it('warns when using createRoot() + .render', () => {
+    const root = ReactDOM.createRoot(document.createElement('div'));
+    expect(() => {
+      TestRenderer.act(() => {
+        root.render(<App />);
+      });
+    }).toWarnDev(
+      [
+        'In Concurrent or Sync modes, the "scheduler" module needs to be mocked',
+        "It looks like you're using the wrong act()",
+      ],
+      {
+        withoutStack: true,
+      }
+    );
+  });
+}