From 27691403c7fcd6b11b112741a01b5473759d5e10 Mon Sep 17 00:00:00 2001 From: Andrew Clark Date: Wed, 8 Jun 2022 12:24:48 -0400 Subject: [PATCH] Fix check_error_codes CI job The diff command was missing a --quiet argument, causing the job not to fail when unminified messages were found. This commit will cause CI to fail because there's an unminified error in main. The unminified error will be fixed by #24688. --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 327ea1b5e0a93..2a259a76a5cd9 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -329,7 +329,7 @@ jobs: name: Search build artifacts for unminified errors command: | yarn extract-errors - git diff || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false) + git diff --quiet || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false) yarn_test: docker: *docker