Enable MessageLoop implementation by default (#16408)

facebook · Sep 5, 2019 · 040ca0f · 040ca0f
1 parent d96f478
commit 040ca0f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/packages/scheduler/src/SchedulerFeatureFlags.js b/packages/scheduler/src/SchedulerFeatureFlags.js
@@ -10,5 +10,5 @@ export const enableSchedulerDebugging = false;
 export const enableIsInputPending = false;
 export const requestIdleCallbackBeforeFirstFrame = false;
 export const requestTimerEventBeforeFirstFrame = false;
-export const enableMessageLoopImplementation = false;
+export const enableMessageLoopImplementation = true;
 export const enableProfiling = __PROFILE__;
diff --git a/...eduler/src/__tests__/SchedulerDOM-test.js → ..._tests__/SchedulerRAFOld-test.internal.js b/...eduler/src/__tests__/SchedulerDOM-test.js → ..._tests__/SchedulerRAFOld-test.internal.js
@@ -16,7 +16,9 @@ type FrameTimeoutConfigType = {
   timePastFrameDeadline: ?number,
 };
 
-describe('SchedulerDOM', () => {
+// Note: this is testing the implementation that we turned off.
+// enableMessageLoopImplementation is true on master.
+describe('SchedulerRAFOld', () => {
   let rAFCallbacks = [];
   let postMessageCallback;
   let postMessageEvents = [];
@@ -101,6 +103,7 @@ describe('SchedulerDOM', () => {
       ),
     );
 
+    require('scheduler/src/SchedulerFeatureFlags').enableMessageLoopImplementation = false;
     Scheduler = require('scheduler');
   });
 

diff --git a/packages/scheduler/src/forks/SchedulerFeatureFlags.www.js b/packages/scheduler/src/forks/SchedulerFeatureFlags.www.js
@@ -9,9 +9,9 @@
 export const {
   enableIsInputPending,
   enableSchedulerDebugging,
-  requestIdleCallbackBeforeFirstFrame,
-  requestTimerEventBeforeFirstFrame,
-  enableMessageLoopImplementation,
 } = require('SchedulerFeatureFlags');
 
 export const enableProfiling = __PROFILE__;
+export const requestIdleCallbackBeforeFirstFrame = false;
+export const requestTimerEventBeforeFirstFrame = false;
+export const enableMessageLoopImplementation = true;