[NavigationExperimental] Use active scene passed in props by NavigationTransitioner
#8298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @hedgerwang and @gabelevi to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
jmurzy
changed the title
props by NavigationTransitionerprops by NavigationTransitioner
|
lgtm :) |
NavigationTransitioner now passes the currently active `scene` in `NavigationTransitionProps`. This simplifies the handling of transition changes when rendering overlay. See facebook/react-native@c57bac4
jmurzy
force-pushed
the
use-NavigationTransitionProps
branch
from
8572b37
to
fec5c8b
Compare
|
/cc @ericvicenti |
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
Thanks @jmurzy! |
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: With facebook/react-native@c57bac4, `NavigationTransitioner` passes the currently active `scene` in transition `props`. This simplifies the handling of transition changes when rendering overlay. 🍺 Closes facebook#8298 Differential Revision: D3533447 Pulled By: ericvicenti fbshipit-source-id: df568dc5cf5d57d8948b9f0400a8d693cf5564e1
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: With facebook/react-native@c57bac4, `NavigationTransitioner` passes the currently active `scene` in transition `props`. This simplifies the handling of transition changes when rendering overlay. 🍺 Closes facebook#8298 Differential Revision: D3533447 Pulled By: ericvicenti fbshipit-source-id: df568dc5cf5d57d8948b9f0400a8d693cf5564e1
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
<img width="740" alt="Screen Shot 2020-05-20 at 16 31 30" src="https://user-images.githubusercontent.com/1174278/82458770-673d8880-9ab7-11ea-81d3-8ac0c1e52705.png">
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: With facebook/react-native@c57bac4, `NavigationTransitioner` passes the currently active `scene` in transition `props`. This simplifies the handling of transition changes when rendering overlay. 🍺 Closes facebook/react-native#8298 Differential Revision: D3533447 Pulled By: ericvicenti fbshipit-source-id: df568dc5cf5d57d8948b9f0400a8d693cf5564e1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With c57bac4,
NavigationTransitionerpasses the currently activescenein transitionprops. This simplifies the handling of transition changes when rendering overlay.🍺