【iOS】Fix timer background state when App is launched from background #39347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@zhongwuzw CircleCI complains about failing unit tests here Could you please take a look? |
|
@dmytrorykun Thanks for review, test failed has fixed. |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mikelehen
reviewed
Sep 9, 2023
cipolleschi
requested changes
Sep 9, 2023
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Sep 11, 2023
|
@dmytrorykun merged this pull request in a4ea737. |
Titozzz
pushed a commit
that referenced
this pull request
Sep 11, 2023
…39347) Summary: Fixes #38711 ## Changelog: [IOS] [FIXED] - Fix timer background state when App is launched from background Pull Request resolved: #39347 Test Plan: Please see #38711 Reviewed By: cipolleschi Differential Revision: D49101979 Pulled By: dmytrorykun fbshipit-source-id: e25b182539f39e4465fa40e51288d88c68967b31
This was referenced Jan 8, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #38711
Changelog:
[IOS] [FIXED] - Fix timer background state when App is launched from background
Test Plan:
Please see #38711