[LOCAL] Make sure Java Toolchain and source/target level is applied to all projects

[cortinico]

Summary:

This should fix reactwg/react-native-releases#54 (comment) by making sure we set JDK source/target level to 11 for all the modules.

Changelog:

[INTERNAL] - Make sure Java Toolchain and source/target level is applied to all projects

Test Plan:

cc @Kudo

[Kudo]

the solution works for the me. however i feel the way to apply java version for all projects is intrusive and afraid if that may break some third party libraries. especially this is done in RNGP where people don't have a way to change it (expect patch-package), would recommend to have a special property to disable this feature. so if there are some errors, people could add something like reactNativeGradlePlugin.forceJavaVersion=false into gradle.properties.

[cortinico]

so if there are some errors, people could add something like reactNativeGradlePlugin.forceJavaVersion=false into gradle.properties.

Yup I could and it probably makes sense. However there is no way to selectively disable this for some of the libraries

[Kudo]

However there is no way to selectively disable this for some of the libraries

so we may have comma splitting string for the property like reactNativeGradlePlugin.forceJavaVersionExcludedProjects
not sure whether that's too complicated. anyway, either way (disable all or disable selectively) looks good to me.

  fun configureJavaToolChains(input: Project) {
    val excludeProjects = (input.rootProject.findProperty("reactNativeGradlePlugin.forceJavaVersionExcludedProjects") as String?)?.split(",") ?: emptyList()
    input.rootProject.allprojects { project ->
      if (excludeProjects.contains(project.name)) {
        return@allprojects
      }
      // ...
    }
  }

[cortinico]

@Kudo I've added a killswitch. I don't think there will be scenarios where we need to selectively turn this off for a library as Java versions are generally forward compatible (i.e. Java 8 code is valid Java 11 code).

If this is not the case, we can add specific handling in a point release

[Kudo]

nit: it's hasProperty so react.internal.disableJavaVersionAlignment=false will also disable the java version enforcement. but it doesn't really matter though 😅

[Kudo]

doesn't have permission to approve the pr, but it looks good to me. thanks @cortinico.

[cortinico]

it's hasProperty so react.internal.disableJavaVersionAlignment=false will also disable the java version enforcement. but it doesn't really matter though 😅

Yeah I prefer this approach as the property is called disable... so we won't have to handle all the boolean cases (true/True/1/etc). Plus it's an .internal. property so no need to be super strict here

[kelset]

(CI is failing 'cause it's not rebased on top of the branch, go ahead and merge anyway, we're still addressing all the various ❌)

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,545,805	-194,752
android	hermes	armeabi-v7a	7,860,130	-191,491
android	hermes	x86	9,024,833	-206,050
android	hermes	x86_64	8,879,939	-202,291
android	jsc	arm64-v8a	9,145,587	-157,578
android	jsc	armeabi-v7a	8,335,670	-156,164
android	jsc	x86	9,198,939	-165,631
android	jsc	x86_64	9,457,119	-162,906

Base commit: a244209
Branch: main