Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNGP - Various improvements needed for 3rd party libs #35496

Closed
wants to merge 1 commit into from

Commits on Nov 28, 2022

  1. RNGP - Various improvements needed for 3rd party libs

    Summary:
    This commit includes a series of fixes needed for better integration with libraries for 0.71:
    - I've added an `android/README.md` file as some libraries were failing the build if the folder was missing
    - RNGP now applies dep substitution on app and all the libraries project
    - RNGP now adds repositories on app and all the libraries project
    - I've removed the maven local repo to the `/android` folder as now is empty
    - I've fixed the path for the JSC repo for Windows users
    - I've added a bit of backward compat by re-adding an empty `project.react.ext` block that libraries might read from.
    - I've removed `codegenDir` from the `GenerateCodegenArtifactsTask` which was unused.
    
    Changelog:
    [Internal] [Changed] - RNGP - Various improvements needed for 3rd party libs
    
    Differential Revision: D41549489
    
    fbshipit-source-id: 177f58675c281f349ba9437beadf7bbcab9e5a96
    cortinico authored and facebook-github-bot committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    718952c View commit details
    Browse the repository at this point in the history