Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reactnativejni to be consumed via prefab #35461

Closed
wants to merge 5 commits into from
Closed

Allow reactnativejni to be consumed via prefab #35461

wants to merge 5 commits into from

Commits on Nov 24, 2022

  1. Consolidate hermes-executor-debug and -release inside a single target 

    Summary:
Historically, we used to have hermes-executor debug and release as separate dynamic libraries.
This makes it impossible to prefab this library, so I have to reconcile it into a single library.

This will also help keep the setup consistent with the internal (BUCK) where we have a single target.

Changelog:
[Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target

Differential Revision: D41519119

fbshipit-source-id: 162640dd424253d8d5645602ad764397fad08127
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    c3a48c8 View commit details
    Browse the repository at this point in the history

  2. Expose hermes-executor to be consumed via prefab 

    Summary:
This exposes `hermes-executor` to be consumed via prefab so that
libraries can depend on it and use its symbols if needed (Expo and Reanimated need it).

Changelog:
[Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab

Differential Revision: D41520019

fbshipit-source-id: 79e7bea4e9da5f49396bbc64ff2f3b9d6acd8cdb
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    e3ae131 View commit details
    Browse the repository at this point in the history

  3. Add prefab for _uimanager _scheduler and _mounting 

    Summary:
We're adding prefab support for those modules as they're needed by Reanimated
and we're exposing headers for them as well.

Changelog:
[Internal] [Changed] - Add prefab for _uimanager _scheduler and _mounting

Differential Revision: D41520606

fbshipit-source-id: 265ccbc79c2f73a47a41e70eff8cbe0ae473bea0
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    a0c5d09 View commit details
    Browse the repository at this point in the history

  4. Add missing headers to react_nativemodule_core prefab module 

    Summary:
Reanimated reported that `react_nativemodule_core` was missing some headers.
Specifically the one from ReactAndroid::react_debug, ReactAndroid::react_render_core, ReactAndroid::glog,
and ReactAndroid::react_render_debug.

I'm adding them here so they get included in the shipped headers for `react_nativemodule_core`

Changelog:
[Internal] [Changed] - Add missing headers to `react_nativemodule_core` prefab module

Differential Revision: D41520751

fbshipit-source-id: ded06ea56275a63e3009d9fd99e2c8e78181937b
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    acc99d5 View commit details
    Browse the repository at this point in the history

  5. Allow reactnativejni to be consumed via prefab 

    Summary:
This is another library which is adding prefab support as it's needed by
Expo libraries and Reanimated.

Changelog:
[Internal] [Changed] - Allow `reactnativejni` to be consumed via prefab

Reviewed By: cipolleschi

Differential Revision: D41520801

fbshipit-source-id: a78c1ac04c2b9181422f3e7f9f6e6d9d39c972ea
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ce54f81 View commit details
    Browse the repository at this point in the history