Fix ignored --projectRoot/watchFolders arguments #21165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Sep 18, 2018
local-cli/server/runServer.js
Outdated
| @@ -58,6 +58,8 @@ async function runServer(args: Args, config: ConfigT) { | |||
| config.server.port = args.port; | |||
| config.reporter = reporter; | |||
| config.resetCache = args.resetCache; | |||
| config.projectRoot = args.projectRoot; | |||
| config.watchFolders = args.watchFolders; | |||
There was a problem hiding this comment.
Cannot assign args.watchFolders to config.watchFolders because read-only array type [1] is incompatible with array type [2].
oblador
force-pushed
the
fix-metro-roots
branch
from
1bb2aef
to
20f4e87
Compare
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 18, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@oblador merged commit 9fca769 into Once this commit is added to a release, you will see the corresponding version tag below the description at 9fca769. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Sep 21, 2018
Summary: Due to Kureev's cleanup in c4a66a8 some arguments are no longer properly passed to metro, but just the default values. This broke the `--projectRoot` and `--watchFolders` arguments used by storybook to change the bundle entrypoint. This PR simply fixes the regression by assigning these values from argv instead of reading config defaults. Related: the undocumented `REACT_NATIVE_APP_ROOT` env var is broken, not sure for how long, but I can fix it as a part of this PR or make a new one. Pull Request resolved: #21165 Differential Revision: D9929642 Pulled By: hramos fbshipit-source-id: 00485a0429bd4301de03e5cb455e928878c4ba8f
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Due to Kureev's cleanup in facebook/react-native@c4a66a8 some arguments are no longer properly passed to metro, but just the default values. This broke the `--projectRoot` and `--watchFolders` arguments used by storybook to change the bundle entrypoint. This PR simply fixes the regression by assigning these values from argv instead of reading config defaults. Related: the undocumented `REACT_NATIVE_APP_ROOT` env var is broken, not sure for how long, but I can fix it as a part of this PR or make a new one. Pull Request resolved: facebook/react-native#21165 Differential Revision: D9929642 Pulled By: hramos fbshipit-source-id: 00485a0429bd4301de03e5cb455e928878c4ba8f
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Due to Kureev's cleanup in facebook@c4a66a8 some arguments are no longer properly passed to metro, but just the default values. This broke the `--projectRoot` and `--watchFolders` arguments used by storybook to change the bundle entrypoint. This PR simply fixes the regression by assigning these values from argv instead of reading config defaults. Related: the undocumented `REACT_NATIVE_APP_ROOT` env var is broken, not sure for how long, but I can fix it as a part of this PR or make a new one. Pull Request resolved: facebook#21165 Differential Revision: D9929642 Pulled By: hramos fbshipit-source-id: 00485a0429bd4301de03e5cb455e928878c4ba8f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to @Kureev's cleanup in c4a66a8 some arguments are no longer properly passed to metro, but just the default values. This broke the
--projectRootand--watchFoldersarguments used by storybook to change the bundle entrypoint.This PR simply fixes the regression by assigning these values from argv instead of reading config defaults.
Related: the undocumented
REACT_NATIVE_APP_ROOTenv var is broken, not sure for how long, but I can fix it as a part of this PR or make a new one.Test Plan:
I created a new folder called
newrootwith a differentindex.js, started metro withreact-native start --projectRoot newrootand got new content.Release Notes:
[CLI] [BUGFIX] [local-cli/server/runServer.js] - Fix --projectRoot/watchFolders arguments ignored