android compileSdkVersion 26, use buildToolsVersion 26.0.3 #19257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
react-native-bot
added
Missing Changelog
|
Maybe use support library 26.1.0 and start migrating to Lifecycles from Architecture Components in future releases. https://developer.android.com/topic/libraries/support-library/revisions |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
May 15, 2018
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
13 tasks
|
new PR that passes CI #19662 |
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Starting August 2018, Google Play will require targetSdkVersion 26 for new applications, and November 2018 for application updates. This PR will use Android build tools 26.0.3 and compilerSdk 26, then support library version 26.0.2 to make targeting 26 easier in the future. I think this PR will help to people compile and test their applications, thus make transition easier (smoother). Also we'll have opportunity and time to migrate code to target 26. facebook#18095 React Native on android must work as usual Closes facebook#19257 Differential Revision: D8010354 Pulled By: mdvacca fbshipit-source-id: 63ba03585e918b38c2a2adb5d2f2e85d7ce46fae
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
Summary: Starting August 2018, Google Play will require targetSdkVersion 26 for new applications, and November 2018 for application updates. This PR will use Android build tools 26.0.3 and compilerSdk 26, then support library version 26.0.2 to make targeting 26 easier in the future. I think this PR will help to people compile and test their applications, thus make transition easier (smoother). Also we'll have opportunity and time to migrate code to target 26. facebook/react-native#18095 React Native on android must work as usual Closes facebook/react-native#19257 Differential Revision: D8010354 Pulled By: mdvacca fbshipit-source-id: 63ba03585e918b38c2a2adb5d2f2e85d7ce46fae
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Starting August 2018, Google Play will require targetSdkVersion 26 for new applications, and November 2018 for application updates. This PR will use Android build tools 26.0.3 and compilerSdk 26, then support library version 26.0.2 to make targeting 26 easier in the future. I think this PR will help to people compile and test their applications, thus make transition easier (smoother). Also we'll have opportunity and time to migrate code to target 26. facebook/react-native#18095 React Native on android must work as usual Closes facebook/react-native#19257 Differential Revision: D8010354 Pulled By: mdvacca fbshipit-source-id: 63ba03585e918b38c2a2adb5d2f2e85d7ce46fae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting August 2018, Google Play will require targetSdkVersion 26 for new applications, and November 2018 for application updates.
This PR will use Android build tools 26.0.3 and compilerSdk 26, then support library version 26.0.2 to make targeting 26 easier in the future.
I think this PR will help to people compile and test their applications, thus make transition easier (smoother). Also we'll have opportunity and time to migrate code to target 26.
#18095
Test Plan
React Native on android must work as usual
Release Notes