From b78e50d9c56925a8fdfa1e5fdd6a91d98d917ec6 Mon Sep 17 00:00:00 2001 From: Fred Blau Date: Mon, 27 Mar 2017 17:54:26 -0400 Subject: [PATCH 1/2] Allow specifying an appId to run-android --- local-cli/runAndroid/runAndroid.js | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/local-cli/runAndroid/runAndroid.js b/local-cli/runAndroid/runAndroid.js index 5cc2b13bc9f172..0ce65d2950252b 100644 --- a/local-cli/runAndroid/runAndroid.js +++ b/local-cli/runAndroid/runAndroid.js @@ -90,24 +90,26 @@ function buildAndRun(args) { 'utf8' ).match(/package="(.+?)"/)[1]; + const packageNameWithSuffix = args.appIdSuffix ? packageName + '.' + args.appIdSuffix : packageName; + const adbPath = getAdbPath(); if (args.deviceId) { if (isString(args.deviceId)) { - runOnSpecificDevice(args, cmd, packageName, adbPath); + runOnSpecificDevice(args, cmd, packageNameWithSuffix, packageName, adbPath); } else { console.log(chalk.red('Argument missing for parameter --deviceId')); } } else { - runOnAllDevices(args, cmd, packageName, adbPath); + runOnAllDevices(args, cmd, packageNameWithSuffix, packageName, adbPath); } } -function runOnSpecificDevice(args, gradlew, packageName, adbPath) { +function runOnSpecificDevice(args, gradlew, packageNameWithSuffix, packageName, adbPath) { let devices = adb.getDevices(); if (devices && devices.length > 0) { if (devices.indexOf(args.deviceId) !== -1) { buildApk(gradlew); - installAndLaunchOnDevice(args, args.deviceId, packageName, adbPath); + installAndLaunchOnDevice(args, args.deviceId, packageNameWithSuffix, packageName, adbPath); } else { console.log('Could not find device with the id: "' + args.deviceId + '".'); console.log('Choose one of the following:'); @@ -150,9 +152,9 @@ function tryInstallAppOnDevice(args, device) { } } -function tryLaunchAppOnDevice(device, packageName, adbPath, mainActivity) { +function tryLaunchAppOnDevice(device, packageNameWithSuffix, packageName, adbPath, mainActivity) { try { - const adbArgs = ['-s', device, 'shell', 'am', 'start', '-n', packageName + '/.' + mainActivity]; + const adbArgs = ['-s', device, 'shell', 'am', 'start', '-n', packageNameWithSuffix + '/' + packageName + + mainActivity]; console.log(chalk.bold( `Starting the app on ${device} (${adbPath} ${adbArgs.join(' ')})...` )); @@ -164,13 +166,13 @@ function tryLaunchAppOnDevice(device, packageName, adbPath, mainActivity) { } } -function installAndLaunchOnDevice(args, selectedDevice, packageName, adbPath) { +function installAndLaunchOnDevice(args, selectedDevice, packageNameWithSuffix, packageName, adbPath) { tryRunAdbReverse(selectedDevice); tryInstallAppOnDevice(args, selectedDevice); - tryLaunchAppOnDevice(selectedDevice, packageName, adbPath, args.mainActivity); + tryLaunchAppOnDevice(selectedDevice, packageNameWithSuffix, packageName, adbPath, args.mainActivity); } -function runOnAllDevices(args, cmd, packageName, adbPath){ +function runOnAllDevices(args, cmd, packageNameWithSuffix, packageName, adbPath){ try { const gradleArgs = []; if (args.variant) { @@ -215,14 +217,14 @@ function runOnAllDevices(args, cmd, packageName, adbPath){ if (devices && devices.length > 0) { devices.forEach((device) => { tryRunAdbReverse(device); - tryLaunchAppOnDevice(device, packageName, adbPath, args.mainActivity); + tryLaunchAppOnDevice(device, packageNameWithSuffix, packageName, adbPath, args.mainActivity); }); } else { try { // If we cannot execute based on adb devices output, fall back to // shell am start const fallbackAdbArgs = [ - 'shell', 'am', 'start', '-n', packageName + '/.MainActivity' + 'shell', 'am', 'start', '-n', packageNameWithSuffix + '/' + packageName + '.MainActivity' ]; console.log(chalk.bold( `Starting the app (${adbPath} ${fallbackAdbArgs.join(' ')}...` @@ -286,6 +288,10 @@ module.exports = { description: '--flavor has been deprecated. Use --variant instead', }, { command: '--variant [string]', + }, { + command: '--appIdSuffix [string]', + description: 'Specify an applicationIdSuffix to launch after build.', + default: '', }, { command: '--main-activity [string]', description: 'Name of the activity to start', From f6b8e8350c1659222605f7e96abbe23dc78b6550 Mon Sep 17 00:00:00 2001 From: Fred Blau Date: Mon, 3 Apr 2017 15:44:07 -0400 Subject: [PATCH 2/2] Fix typo in shell am start + activity name --- local-cli/runAndroid/runAndroid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local-cli/runAndroid/runAndroid.js b/local-cli/runAndroid/runAndroid.js index 0ce65d2950252b..5cf9d8eba1cc28 100644 --- a/local-cli/runAndroid/runAndroid.js +++ b/local-cli/runAndroid/runAndroid.js @@ -154,7 +154,7 @@ function tryInstallAppOnDevice(args, device) { function tryLaunchAppOnDevice(device, packageNameWithSuffix, packageName, adbPath, mainActivity) { try { - const adbArgs = ['-s', device, 'shell', 'am', 'start', '-n', packageNameWithSuffix + '/' + packageName + + mainActivity]; + const adbArgs = ['-s', device, 'shell', 'am', 'start', '-n', packageNameWithSuffix + '/' + packageName + '.' + mainActivity]; console.log(chalk.bold( `Starting the app on ${device} (${adbPath} ${adbArgs.join(' ')})...` ));