Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
Fixes #13077: on Windows, when using
autocrlf=true
, thenreact-native link
will fail to recognize that Android libraries have already been linked and will link them again.Android's
isInstalled.js
nowtrim
s the pattern it's looking for so that it's newline-neutral. Note thatreact-native link
will still unconditionally use a\n
when patching the file, but git will automatically adjust this according toautocrlf
upon a push + pull.Test Plan (required)
Had some problems due to git newline manipulation to add separate
build.gradle
samples that will consistently have\n
or\r\n
on all platforms. :-/