Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text] SampleApp's Text tag display error on device! #947

Closed
yueliangwen opened this issue Apr 21, 2015 · 9 comments
Closed

[Text] SampleApp's Text tag display error on device! #947

yueliangwen opened this issue Apr 21, 2015 · 9 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@yueliangwen
Copy link

SampleApp display<Text style={styles.welcome}>Welcome to React Native!</Text> error on device(iphone6 plus)!Show Welcome to React only, Native is gone!

@brentvatne
Copy link
Collaborator

@yueliangwen - this is on the base project, with nothing changed? And it does not happen in the simulator?

Can anyone else with an iPhone 6 plus confirm?

@yueliangwen
Copy link
Author

@brentvatne - Change localhost to the ip address of my computer only. It's all right in the simulator!
Welcome to Reactive Native! is right! Welcome to ReacT Native! is right! Keep Welcome to React Native!, and change fontSize of styles.welcome to 24 is right! Very strange!

@cgarvis
Copy link

cgarvis commented May 15, 2015

We've experienced something similar with text on iPhone 6s and the iPhone 6 simulator. No issues on iPhone4s and iPhone 5s. I'll see if I can start a new project and replicate.

@cgarvis
Copy link

cgarvis commented May 15, 2015

Screenshots:

iPhone 5s
iphone5s

iPhone 6 Plus
iphone6plus

Seems that iPhone 6 is fine.

@esauter5
Copy link
Contributor

screen shot 2015-05-26 at 3 23 13 pm

When adding some height to the text element, you can see that the last word wraps to a new line. If I don't set an explicit height, the wrapped text is not visible. It would appear that the whatever size React Native is setting the text element to is a pixel or two short causing it to wrap.

@esauter5
Copy link
Contributor

A temporary hack I've found to work is adding an extra space of text to the end of Text components. The seems to add the extra few pixels necessary so that nothing gets cut off. I have a wrapper around the React Text component so I've added this extra space there so that I don't have to manually fix each individual problematic component. I also added an extra space at the beginning to try to balance things out.

@tadeuzagallo tadeuzagallo assigned tadeuzagallo and a2 and unassigned tadeuzagallo May 26, 2015
@brentvatne brentvatne changed the title SampleApp's Text tag display error on device! [Text] SampleApp's Text tag display error on device! May 30, 2015
@brentvatne
Copy link
Collaborator

@esauter5 - is this still happening for you on master? Not much activity on here and haven't run into it myself, so closing for now

@esauter5
Copy link
Contributor

@brentvatne Not sure. The hack I used fixed the issue so I haven't run into it. When I get some time I'll take some time to figure out if I still see it without the hack and if so I'll let you know.

@brentvatne
Copy link
Collaborator

Thanks for the quick response @esauter5 - nobody has reported on this in a while so it is probably fixed but it would be amazing if you were able to verify that when you get the chance! ❤️

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants