-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.26-rc build isue #7566
Comments
you need to add |
Anyone wants to submit a Pull Request that updates XCode project with |
The change should be similar to 8aa82d3 |
What changed in 0.26 that we now need the new linker flag? |
But e2e tests pass so the new project template is correct? |
| But e2e tests pass so the new project template is correct? E2e failed to link after this change 033e7c8 Here is log: https://travis-ci.org/facebook/react-native/jobs/124793055 |
|| The change should be similar to 8aa82d3 The new project template is now correct and e2e pass. |
Do we even have a clean interface for doing that? Currently it looks that we just copy files and merge them with the user ones. That would be super easy with We might not be able to do it
which upgrades your project from X to Y (in this case 0.26) applying all defined upgrades one after another. We can merge it later to CC: @mkonicek @bestander |
Can we script
into the update script? For the one-off thing until rnpm is merged. |
That would work indeed. I'll update this issue in the morning once the upgrade code is there. |
@bestander where do you think it's appropriate to add that |
@grabbou after thinking about it and looking at https://github.com/facebook/react-native/blob/master/local-cli/upgrade/upgrade.js, we don't put any modifying commands to this script. I think we should do similar to this: https://github.com/facebook/react-native/blob/master/local-cli/upgrade/upgrade.js#L49:
|
And @grabbou kudos for doing that! |
Sounds good! https://github.com/rnpm/rnpm-plugin-upgrade Here's the plugin with the installation steps. I decided to align its versions with the React Native ones, so it's easier for us to handle changes. I already published it to We can add detection of the version later, for now I just made it dead simple. |
Here's the PR: #7614 |
@chirag04 You saved my life! |
@chirag04 It is ok after i added |
I have added https://github.com/smore-inc/react-native-segment-io-analytics and I am now getting this issue.
Is this a RN issue or an issue of the package?
|
solved! Had to add |
@thorbenandresen Thanks when u said TEST target , I didn't understand what does it meant and where was it. Finally figure it out and here it was. |
Ran into this too. Had to also add to Test target. |
Yep just ran into this issue when I changed my scheme to run in Release configuration (worked during debug). Had to add -lc++ to the test target as pictured by @mazicky |
I just had to do this too, thanks @mazicky and everyone else. |
For me the only way to fix the issue was to add |
@thorbenandresen, thanks pro |
Undefined symbols for architecture x86_64:
"std::terminate()", referenced from:
___clang_call_terminate in libReact.a(RCTJSCExecutor.o)
"___cxa_begin_catch", referenced from:
___clang_call_terminate in libReact.a(RCTJSCExecutor.o)
"___gxx_personality_v0", referenced from:
-[RCTJavaScriptContext initWithJSContext:onThread:] in libReact.a(RCTJSCExecutor.o)
-[RCTJavaScriptContext init] in libReact.a(RCTJSCExecutor.o)
-[RCTJavaScriptContext invalidate] in libReact.a(RCTJSCExecutor.o)
_RCTNSErrorFromJSError in libReact.a(RCTJSCExecutor.o)
+[RCTJSCExecutor runRunLoopThread] in libReact.a(RCTJSCExecutor.o)
-[RCTJSCExecutor init] in libReact.a(RCTJSCExecutor.o)
-[RCTJSCExecutor context] in libReact.a(RCTJSCExecutor.o)
...
ld: symbol(s) not found for architecture x86_64
None of the above, create a bug report
Make sure to add all the information needed to understand the bug so that someone can help. If the info is missing we'll add the 'Needs more information' label and close the issue until there is enough information.
The text was updated successfully, but these errors were encountered: