Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't POPAnimation available in the OSS fork? #708

Closed
klvnptr opened this issue Apr 6, 2015 · 5 comments
Closed

Why isn't POPAnimation available in the OSS fork? #708

klvnptr opened this issue Apr 6, 2015 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@klvnptr
Copy link

klvnptr commented Apr 6, 2015

Hey Guys.

Just curious, why isn't POPAnimation available in the OSS fork as it is referred on:

https://github.com/facebook/react-native/blob/master/Libraries/Animation/POPAnimationMixin.js#L17

Thanks so much for this great tool!

@vjeux
Copy link
Contributor

vjeux commented Apr 6, 2015

Multiple reasons:

  1. We haven't figured out how to deal with obj-c dependencies so it was hard to embed POP
  2. Pop runs in the main process, however there's a way on iOS to run code in a completely different process via CoreAnimation.
  3. It doesn't work on Android

But ultimately, we haven't figured out a good general api for doing animations. Instead of exposing some half backed version (that are working) and trashing people in open source, we prefer to wait and iterate on it internally until we find something that we want people to use and we want to maintain.

@klvnptr
Copy link
Author

klvnptr commented Apr 6, 2015

Perfectly clear. Thanks so much and keep up with this awesome work!

@klvnptr klvnptr closed this as completed Apr 6, 2015
@brentvatne
Copy link
Collaborator

#1365 (comment)

@klvnptr
Copy link
Author

klvnptr commented May 31, 2015

Thanks Brent!

@brentvatne
Copy link
Collaborator

No problem @mcz 😄

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants