Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly solve the issue with TalkBack order #47213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dnhan1707
Copy link

Solving issue #45096

Summary:

Change the order of setter in onInitializeAccessibilityNodeInfo and ensure the getTalkbackDescription return correct text for TalkBack

  • The order of TalkBack is not set correctly due to the way that we use setter in the method onInitializeAccessibilityNodeInfo. (It can be found in packages/react-native/ReactAndroid/src/main/java/react/ReactAccessibilityDelegate.java
    The method goes from top to bottom and the setters was in order of:
    setRole -> setTooltipText -> setLabeledBy -> setState -> addAction -> setCollectionItemInfo
    ->setRangeInfo
    Screenshot 2024-10-25 165910

  • I also update the getTalkbackDescription to return the correct order of text for TalkBack by returning the talkbackSegments at once instead of keep checking twice
    Screenshot 2024-10-25 165924

…nsure the getTalkbackDescription return the correct order of text for TalkBack by returning the talkbackSegments at once instead of keep checking twice
@facebook-github-bot
Copy link
Contributor

Hi @dnhan1707!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 9829291

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants