earlyjs: Integrate c++ pipeline with console.error #47169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64506069 |
RSNara
force-pushed
the
export-D64506069
branch
3 times, most recently
from
aecdb0d
to
3b159d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64506069 |
RSNara
force-pushed
the
export-D64506069
branch
from
3b159d4
to
e161724
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64506069 |
RSNara
force-pushed
the
export-D64506069
branch
from
e161724
to
30010b0
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Oct 25, 2024
Summary: ## Changes If the c++ pipeline is active: If someone calls console.error: - The c++ pipeline will report it as a soft error If someone reports an error: - The c++ pipeline will log it via console.error Changelog: [Internal] Differential Revision: D64506069
|
This pull request was exported from Phabricator. Differential Revision: D64506069 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Oct 25, 2024
Summary: ## Changes If the c++ pipeline is active: If someone calls console.error: - The c++ pipeline will report it as a soft error If someone reports an error: - The c++ pipeline will log it via console.error Changelog: [Internal] Differential Revision: D64506069
RSNara
force-pushed
the
export-D64506069
branch
from
30010b0
to
f31d429
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64506069 |
Summary: Now, handleError can be called with a JSError that wraps a non-error object! Changelog: [Internal] Reviewed By: javache Differential Revision: D64706198
…peline (facebook#47165) Summary: The c++ pipeline needs a javascript interface. We could just re-use exceptions manager (for now). Changelog: [Internal] Reviewed By: javache Differential Revision: D64779068
Summary: This method wasn't used from javascript. Changelog: [Internal] Reviewed By: javache Differential Revision: D64607415
Summary: I couldn't find any usages of this method in javascript. Removing, so that the native code is easier to read. Changelog: [Internal] Reviewed By: javache Differential Revision: D64606928
Summary: Now, all ios apps will just be integrated with the c++ error reporting pipeline, with zero configuration. Changelog: [Internal] Reviewed By: philIip Differential Revision: D64615457
Summary: ## Changes If the c++ pipeline is active: If someone calls console.error: - The c++ pipeline will report it as a soft error If someone reports an error: - The c++ pipeline will log it via console.error Changelog: [Internal] Differential Revision: D64506069
RSNara
force-pushed
the
export-D64506069
branch
from
f31d429
to
50270fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64506069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes
If the c++ pipeline is active:
If someone calls console.error:
If someone reports an error:
Changelog: [Internal]
Differential Revision: D64506069