-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
earlyjs: Integrate c++ pipeline with console.error #47169
base: main
Are you sure you want to change the base?
Conversation
This pull request was exported from Phabricator. Differential Revision: D64506069 |
aecdb0d
to
3b159d4
Compare
This pull request was exported from Phabricator. Differential Revision: D64506069 |
3b159d4
to
e161724
Compare
This pull request was exported from Phabricator. Differential Revision: D64506069 |
e161724
to
30010b0
Compare
Summary: ## Changes If the c++ pipeline is active: If someone calls console.error: - The c++ pipeline will report it as a soft error If someone reports an error: - The c++ pipeline will log it via console.error Changelog: [Internal] Differential Revision: D64506069
This pull request was exported from Phabricator. Differential Revision: D64506069 |
Summary: ## Changes If the c++ pipeline is active: If someone calls console.error: - The c++ pipeline will report it as a soft error If someone reports an error: - The c++ pipeline will log it via console.error Changelog: [Internal] Differential Revision: D64506069
30010b0
to
f31d429
Compare
This pull request was exported from Phabricator. Differential Revision: D64506069 |
Summary: Now, handleError can be called with a JSError that wraps a non-error object! Changelog: [Internal] Reviewed By: javache Differential Revision: D64706198
…peline (facebook#47165) Summary: The c++ pipeline needs a javascript interface. We could just re-use exceptions manager (for now). Changelog: [Internal] Reviewed By: javache Differential Revision: D64779068
Summary: This method wasn't used from javascript. Changelog: [Internal] Reviewed By: javache Differential Revision: D64607415
Summary: I couldn't find any usages of this method in javascript. Removing, so that the native code is easier to read. Changelog: [Internal] Reviewed By: javache Differential Revision: D64606928
Summary: Now, all ios apps will just be integrated with the c++ error reporting pipeline, with zero configuration. Changelog: [Internal] Reviewed By: philIip Differential Revision: D64615457
Summary: ## Changes If the c++ pipeline is active: If someone calls console.error: - The c++ pipeline will report it as a soft error If someone reports an error: - The c++ pipeline will log it via console.error Changelog: [Internal] Differential Revision: D64506069
f31d429
to
50270fc
Compare
This pull request was exported from Phabricator. Differential Revision: D64506069 |
Summary:
Changes
If the c++ pipeline is active:
If someone calls console.error:
If someone reports an error:
Changelog: [Internal]
Differential Revision: D64506069