cleanup: ExceptionsManager: Delete reportUnhandledException #47166
+37
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
RSNara
force-pushed
the
export-D64607415
branch
5 times, most recently
from
9d23ab0
to
13f8381
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64607415 |
|
This pull request was exported from Phabricator. Differential Revision: D64607415 |
RSNara
force-pushed
the
export-D64607415
branch
2 times, most recently
from
dcdba79
to
52547ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64607415 |
Summary: Now, handleError can be called with a JSError that wraps a non-error object! Changelog: [Internal] Reviewed By: javache Differential Revision: D64706198
…peline Summary: The c++ pipeline needs a javascript interface. We could just re-use exceptions manager (for now). Changelog: [Internal] Reviewed By: javache Differential Revision: D64779068
Summary: This method wasn't used from javascript. Changelog: [Internal] Reviewed By: javache Differential Revision: D64607415
RSNara
force-pushed
the
export-D64607415
branch
from
52547ed
to
67d9738
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64607415 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Oct 25, 2024
…facebook#47166) Summary: This method wasn't used from javascript. Changelog: [Internal] Reviewed By: javache Differential Revision: D64607415
|
This pull request has been merged in f878896. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This method wasn't used from javascript.
Changelog: [Internal]
Differential Revision: D64607415