Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

earlyjs: Make JsErrorHandler work for all js throwables #47164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RSNara
Copy link
Contributor

@RSNara RSNara commented Oct 22, 2024

Summary:
Now, handleError can be called with a JSError that wraps a non-error object!

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64706198

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 22, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64706198

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64706198

@RSNara RSNara force-pushed the export-D64706198 branch 2 times, most recently from 0da9136 to 1657eb2 Compare October 22, 2024 23:07
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64706198

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64706198

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64706198

RSNara added a commit to RSNara/react-native that referenced this pull request Oct 23, 2024
…cebook#47164)

Summary:

Now, handleError can be called with a JSError that wraps a non-error object!

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64706198
RSNara added a commit to RSNara/react-native that referenced this pull request Oct 23, 2024
…cebook#47164)

Summary:

Now, handleError can be called with a JSError that wraps a non-error object!

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64706198
RSNara added a commit to RSNara/react-native that referenced this pull request Oct 23, 2024
…cebook#47164)

Summary:

Now, handleError can be called with a JSError that wraps a non-error object!

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64706198
Summary:
Now, handleError can be called with a JSError that wraps a non-error object!

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64706198
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64706198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants