feat(iOS): dynamically resolve react native path in Hermes podspec #46181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
okwasniewski
changed the title
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
Aug 23, 2024
|
Thanks for fixing this for all the OOT platforms! |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in b10ed0e. |
|
This pull request was successfully merged by @okwasniewski in b10ed0e When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Summary: This PR is a follow-up after #46181 this change makes sure that if the `require.resolve` fails we still fall back to the old behavior. The `require.resolve` was failing for local builds of OOT platforms (because in OOT platforms mono repo `react-native` is renamed to `react-native-platform-name`) ## Changelog: [IOS] [FIXED] - Fallback to old resolve mechanism when node require fails to resolve react native path Pull Request resolved: #46432 Test Plan: CI Green Reviewed By: christophpurrer Differential Revision: D62577183 Pulled By: cipolleschi fbshipit-source-id: d62d9c2a5eee3546a81d2aad52b7f73763315b18
|
Slightly late thanks, I think I'm running into a similar issue for React Native macOS right now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR modifies hermes-engine.podspec to resolve the path to
react-nativedynamically.In OOT platforms case we often have slightly different versioning, let's say
react-nativeis at 0.75.1 andreact-native-visionosis at 0.75.2. This causes an issue while resolving the prebuilt version of Hermes. We should always get the Hermes tied to thereact-nativepackage version, not the OOT platform.Changelog:
[IOS] [FIXED] - Resolve Hermes prebuilt version based on react-native packge
Test Plan:
Install pods