Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y][iOS] Nested accessibility items not accessible #27147

Closed
cihan-m opened this issue Nov 7, 2019 · 5 comments
Closed

[a11y][iOS] Nested accessibility items not accessible #27147

cihan-m opened this issue Nov 7, 2019 · 5 comments
Labels
Bug Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@cihan-m
Copy link

cihan-m commented Nov 7, 2019

Hello,

This is basically a repeat of #24515. It seems like that issue is locked though, so creating a new one.

React Native version: 0.61.2

System:
    OS: macOS 10.15.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 1.32 GB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 8.11.3 - /usr/local/bin/node
    npm: 6.4.1 - /usr/local/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
  IDEs:
    Android Studio: 3.5 AI-191.8026.42.35.5900203
    Xcode: 11.1/11A1027 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0 
    react-native: 0.61.2 => 0.61.2 
  npmGlobalPackages:
    react-native-cli: 2.0.1

Steps To Reproduce

  1. Use nested Text components for text inline with hyperlinks, or go to this Snack: https://snack.expo.io/@heehee.its.cindy/snack-to-reproduce-nested-accessibility-issues
  2. Turn on Voiceover, swipe around the app
  3. See that there is no way for a user using Voiceover to access the hyperlink to click it

Describe what you expected to happen:
Voiceover user should be able to access the entirety of the text, and the hyperlink (so both the parent Text component and nested Text components). There were two strategies proposed by @sahrens in #24515, can we open that issue back up to continue that discussion?

@cihan-m cihan-m added the Bug label Nov 7, 2019
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Nov 7, 2019
@CoryWritesCode
Copy link

I may be asking the wrong question but why would you nest <Text /> within a <Text />?

@cihan-m
Copy link
Author

cihan-m commented Nov 7, 2019

@CoryWritesCode this is how we’ve been creating text all in one line where different parts of the text needs different styling. For example, if one part of a sentence needs a hyperlink.

Wrapping with a View even with flexWrap “wrap” has some visual issues, unless maybe we create a separate child Text component for every word. So there is a sort of a clunky workaround, however it seems like native iOS and Flutter have a nicer way of handling nested accessibility, that would be nice to have in React Native as well.

@CoryWritesCode
Copy link

I can see that @cihan-m. Makes sense as RN doesn't have a <Span /> type component.

@stale
Copy link

stale bot commented Feb 5, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 5, 2020
@stale
Copy link

stale bot commented Feb 12, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Feb 12, 2020
@facebook facebook locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

3 participants