Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted list on Android is not positioned correctly #24871

Closed
solkaz opened this issue May 15, 2019 · 5 comments
Closed

Inverted list on Android is not positioned correctly #24871

solkaz opened this issue May 15, 2019 · 5 comments
Labels
Bug Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@solkaz
Copy link
Contributor

solkaz commented May 15, 2019

Inverted lists (on Android) are not being "positioned" on screen, which is causing issues with E2E tests using Detox. To be clear, elements within the list are displayed properly, but when viewing the list in react-devtools, the list will not be highlighted, and is supposedly "off screen". iOS does not exhibit this behavior and will be correctly position/highlighted in react-devtools.

React Native version:

info 
  React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
      Memory: 47.72 MB / 16.00 GB
      Shell: 5.7.1 - /usr/local/bin/zsh
    Binaries:
      Node: 8.15.0 - /var/folders/z8/vcctz6491nz5t76b6py0gfd9x3djlb/T/yarn--1557944482755-0.7051974076143663/node
      Yarn: 1.16.0 - /var/folders/z8/vcctz6491nz5t76b6py0gfd9x3djlb/T/yarn--1557944482755-0.7051974076143663/yarn
      npm: 6.4.1 - ~/.nvm/versions/node/v8.15.0/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        API Levels: 23, 25, 27, 28
        Build Tools: 27.0.3, 28.0.2, 28.0.3
        System Images: android-27 | Google Play Intel x86 Atom
    IDEs:
      Android Studio: 3.4 AI-183.5429.30.34.5452501
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3 
      react-native: 0.59.8 => 0.59.8 

Steps To Reproduce

Example repo:
https://github.com/solkaz/react-native-inverted-virtualized-list-issue

  1. Render an inverted FlatList in a debug variant of the Android app.
  2. Inspect the list using the react-devtools and the in-app inspector. The list element in the app will not be highlighted.
  3. Toggling the inverted prop then reexamining the element will then show it being highlighted
  4. Steps 1 & 2 can be used for iOS as well; however, it will correctly position the element and will be highlighted correctly.

Describe what you expected to happen:
The list element will be highlighted when hovered over in react-devtools, and is positioned correctly, when using an inverted FlatList

Android, inverted

Screen Shot 2019-05-15 at 12 59 04 PM

Android, uninverted

Screen Shot 2019-05-15 at 12 58 59 PM

iOS, inverted

Screen Shot 2019-05-15 at 1 07 21 PM

iOS, uninverted

Screen Shot 2019-05-15 at 1 07 27 PM

@solkaz solkaz added the Bug label May 15, 2019
@react-native-bot react-native-bot added the Platform: Android Android applications. label May 15, 2019
@Sharcoux
Copy link

Sharcoux commented May 22, 2019

Probably linked with this : #23635

@stale
Copy link

stale bot commented Aug 20, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 20, 2019
@Sharcoux
Copy link

There is no activity because it is very hard to contribute to this project.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 20, 2019
@stale
Copy link

stale bot commented Nov 18, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 18, 2019
@stale
Copy link

stale bot commented Nov 25, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Nov 25, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

3 participants