Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN 0.59.1 sourcemap error in Android #24059

Closed
xutm opened this issue Mar 20, 2019 · 4 comments
Closed

RN 0.59.1 sourcemap error in Android #24059

xutm opened this issue Mar 20, 2019 · 4 comments
Labels
Bug Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@xutm
Copy link

xutm commented Mar 20, 2019

🐛 Bug Report

RN 0.59.1 sourcemap error in Android.

In Scene.js, add console.log(======rendersss===).

image

But sourcemap is SaleEvent.js

image

image

Environment

react-native: 0.59.1

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: (4) x64 Intel(R) Core(TM) i5-6360U CPU @ 2.00GHz
Memory: 411.95 MB / 8.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 10.2.0 - ~/.nvm/versions/node/v10.2.0/bin/node
Yarn: 1.10.1 - ~/.nvm/versions/node/v10.2.0/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v10.2.0/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
Android SDK:
API Levels: 25, 26, 27, 28
Build Tools: 26.0.0, 26.0.2, 27.0.3, 28.0.3
IDEs:
Android Studio: 3.1 AI-173.4720617
Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmGlobalPackages:
react-native-cli: 2.0.1

@cpojer
Copy link
Contributor

cpojer commented Mar 20, 2019

Can you provide a repository with a repro? Screenshots won't help us solve this issue. Alternatively, you could also try to send a PR with a fix!

@OsamaSaleem95
Copy link

same problem here

@react-native-bot react-native-bot added the Platform: Android Android applications. label Mar 20, 2019
@yurykorzun
Copy link
Contributor

yurykorzun commented Mar 22, 2019

The metro bundler is producing a wrong source map on Android in 0.59.1 and 0.59.0. At least it is consistently happening in my React Native project, but works fine on iOS. I tried to disable JS deltas, it doesn't help.

Related issues #23955 #6946

It could be related to JSC upgrade, but because I don't know how source maps are generated and mapped to running javascript on a device, I don't know exactly what is causing it.

Metro is using this package for generating a source map https://www.npmjs.com/package/source-map

@kelset
Copy link
Contributor

kelset commented Mar 22, 2019

Closing as duplicate of #23955

@kelset kelset closed this as completed Mar 22, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 22, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants