iOS build error after upgrade: library not found for -ljschelpers

[jeremy303]

Environment

React Native Environment Info:
System:
OS: macOS 10.14
CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
Memory: 320.15 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.15.0 - ~/.nvm/versions/node/v10.15.0/bin/node
npm: 6.7.0 - ~/.nvm/versions/node/v10.15.0/bin/npm
Watchman: 4.7.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 20, 23, 24, 25, 26, 27
Build Tools: 23.0.1, 23.0.3, 25.0.0, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 27.0.0, 27.0.1, 27.0.2, 27.0.3
System Images: android-24 | Google Play Intel x86 Atom, android-25 | Google APIs Intel x86 Atom, android-26 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.2 AI-181.5540.7.32.5014246
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: ^16.6.3 => 16.6.3
react-native: ^0.58.3 => 0.58.3
npmGlobalPackages:
react-native-git-upgrade: 0.2.7

Description

Upgraded from 0.57.8 -> 0.58.3 using react-native-git-upgrade and resolved merge conflicts.

When attempting to build for iOS, I receive the following error:

❌  ld: library not found for -ljschelpers

Based on a StackOverflow post regarding a similar linker issue w/ another library, I did try to remove JavasScriptCore.framework and then add it again using Xcode to no avail.

Reproducible Demo

[jeremy303]

Problem solved, but I'm not entirely sure what went wrong I rolled back my git repo and tried react-native-git-upgrade a second time and now things work. There were lines deleted in my project file related to jschelpers, but unfortunately I did't commit a snapshot of the code immediately after my first upgrade attempt, so I can't be certain what changes may of been the result of an automatic git merge gone afoul vs changes introduced by Xcode as I attempted to resolve the issue.

My take away lesson: I think in the future I'll be manually updating my native code based on the diffs provided by rn-diff-purge, vs using react-native-git-upgrade. Or at a minimum, comparing the results of the tool to the diffs.

[dorthwein]

Im running into this as well - any definitive clarity?

[dorthwein]

wanted to note a solution found here #24298