Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNTesterSnapshotTests: Fix testScrollViewExample failure #22696

Closed
hramos opened this issue Dec 18, 2018 · 2 comments
Closed

RNTesterSnapshotTests: Fix testScrollViewExample failure #22696

hramos opened this issue Dec 18, 2018 · 2 comments
Labels
Component: ScrollView Help Wanted :octocat: Issues ideal for external contributors. Platform: iOS iOS applications. Resolution: Fixed A PR that fixes this issue has been merged. Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.

Comments

@hramos
Copy link
Contributor

hramos commented Dec 18, 2018

Help Wanted: Fix ScrollViewExample

test_objc on Circle CI is red due to a failing snapshot test, ScrollViewExample:

RNTesterSnapshotTests
  testScrollViewExample, failed: caught "NSInternalInconsistencyException", "Test failed"
  /Users/distiller/react-native/Libraries/RCTTest/RCTTestRunner.m:235
      RCTAssert(testModule.status != RCTTestStatusPending, @"Test didn't finish within %0.f seconds", kTestTimeoutSeconds);
      RCTAssert(testModule.status == RCTTestStatusPassed, @"Test failed");
    }

The test is defined in JavaScript at RNTester/js/ScrollViewExample.js, and is invoked by RNTesterSnapshotTests.

Steps to reproduce:

  1. Run yarn at the repository root.
  2. Open RNTester/RNTester.xcodeproj on Xcode 10.1.0.
  3. Build RNTester.
  4. Run tests (CMD+U) on an iPhone 6s simulator.
@radko93
Copy link
Contributor

radko93 commented Dec 20, 2018

@hramos I submitted a PR #22729

@hramos
Copy link
Contributor Author

hramos commented Dec 20, 2018

Fixed by #22729

@hramos hramos closed this as completed Dec 20, 2018
@hramos hramos added the Resolution: Fixed A PR that fixes this issue has been merged. label Dec 20, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Dec 20, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: ScrollView Help Wanted :octocat: Issues ideal for external contributors. Platform: iOS iOS applications. Resolution: Fixed A PR that fixes this issue has been merged. Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.
Projects
None yet
Development

No branches or pull requests

3 participants