-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][Animation] Interpolated translateY value causes android view to jump. #21801
Comments
It looks like you are using an older version of React Native. Please update to the latest release, v0.57 and verify if the issue still exists. The ":rewind:Old Version" label will be removed automatically once you edit your original post with the results of running |
The issue still exists on rn 0.57 |
@godofmadness You ever resolve this issue? |
@darylalexjohnson nope, issue still exist. |
Having similar issues.. |
I am also having this issue. Any resolution in sight? My guess is that Y translating the scrollview while scrolling throws off the difference calculation between the start scrollY coordinate and it's relative current scrollY coordinate. I assume this calculation is how the scrollview component does it's scrolling animation. If it's relative point is changing along with the y translation, that would explain the jumping. |
I'm also having this issue using RN 0.57.8. It looks like it only happens when you have a decreasing outputRange, like [100, 0], or in OP's case, [0, -200]. It also happens with animated margins and paddings. |
Does this still happen on 0.58? |
@kelset Yes. Here is a example tested on RN 58.1:
Just create a new project with react-native init and paste it on App.js. Here is a gif of the result: |
Hi, I'm maintaining |
#15445 |
Are there any PRs open to try and fix this? Or commits already on master? |
Can anyone tell me how to trigger re-compile |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
+1 |
2 similar comments
+1 |
+1 |
Having a similar problem currently with an Animated.View that uses translateY. Screenrecorder-2021-11-04-14-14-31-174.0.mp4 |
0.66.3 same only android |
nope |
I was trying to implement collapsible header using reanimated and meet this dumb problem on Android. No matter what I use to animate ScrollView (paddingTop, translateY, height). This is quite serious bug and it exists for a really long time, I don't believe that using react-native I cannot implement such an easy animation on Android... It has redproduced since 2017: #15445 If there aren't any blocks, contributors please pay attention to this problem |
@Deodes maybe you could try react-native-reanimated instead of |
@KingAmo I updated my comment |
Why this silly bug exists for a such really long time? |
still a bug!!! |
Any updates on this? Just ran into this problem on react-native 0.69.5. |
can not make animatable header with Tab View |
we are in 2023 and still a bug, the UI gets vibrated while scrolling on the Android platform RN 0.71.4 |
+1 |
It's really weird that this bug still exist till the day, I managed to overcome it like that so I noticed that the scrollview was bouncing by the height of the translateY, so you can use these conditions on android also you will need the marginBottom on the view of the list to hide the white part on the bottom when translating hope this will help. import Animated, {
Extrapolate,
interpolate,
useAnimatedScrollHandler,
useAnimatedStyle,
useSharedValue,
withTiming,
} from 'react-native-reanimated';
const AnimatedFlashList = Animated.createAnimatedComponent(FlashList);
const scrollY = useSharedValue(0);
const headerHeight = 90; // Height of the header
const progress = useSharedValue(0);
const translateTheshold = 50; // Threshold to start the animation
const scrollHandler = useAnimatedScrollHandler(event => {
const offsetY = event.contentOffset.y;
// scroll down
if (offsetY > scrollY.value && progress.value === 0) {
if (offsetY > translateTheshold) {
progress.value = withTiming(1, {
duration: 500,
});
if (Platform.OS === 'android') {
// subtract header height to scrollY value to fix android bounce issue
scrollY.value =
scrollY.value - headerHeight < 0 ? 0 : scrollY.value - headerHeight;
}
}
// scroll up
} else if (offsetY < scrollY.value && progress.value === 1) {
if (Platform.OS === 'android') {
// add header height to scrollY value to fix android bounce issue
scrollY.value = scrollY.value + headerHeight;
}
progress.value = withTiming(0, {
duration: 500,
});
}
scrollY.value = withTiming(offsetY);
});
const translateYStyle = useAnimatedStyle(() => {
return {
transform: [
{
translateY: interpolate(
progress.value,
[0, 1],
[0, -headerHeight],
Extrapolate.CLAMP,
),
},
],
};
});
<View>
<Animated.View
style={[
{
backgroundColor: 'red',
height: 90,
alignItems: 'center',
justifyContent: 'center',
},
translateYStyle,
]}>
<Text preset="header">hello header</Text>
</Animated.View>
<Animated.View
style={[{flex: 1, marginBottom: -headerHeight}, translateYStyle]}>
<AnimatedFlashList
showsVerticalScrollIndicator={false}
bounces={false}
scrollEventThrottle={16}
onScroll={scrollHandler}
data={claim.attributes.groups}
renderItem={renderItem}
estimatedItemSize={350}
/>
</Animated.View>
</View> Even more I made it a hook so it's reusable import {Platform} from 'react-native';
import {
useSharedValue,
useAnimatedScrollHandler,
withTiming,
useAnimatedStyle,
interpolate,
Extrapolate,
} from 'react-native-reanimated';
interface IUseTranslateHeaderOnScrollProps {
translateTheshold: number;
headerHeight: number;
}
export const useTranslateHeaderOnScroll = ({
headerHeight,
translateTheshold,
}: IUseTranslateHeaderOnScrollProps) => {
const scrollY = useSharedValue(0);
const progress = useSharedValue(0);
const scrollHandler = useAnimatedScrollHandler(event => {
const offsetY = event.contentOffset.y;
// scroll down
if (offsetY > scrollY.value && progress.value === 0) {
if (offsetY > translateTheshold) {
progress.value = withTiming(1, {
duration: 500,
});
if (Platform.OS === 'android') {
// subtract header height to scrollY value to fix android bounce issue
scrollY.value =
scrollY.value - headerHeight < 0 ? 0 : scrollY.value - headerHeight;
}
}
// scroll up
} else if (offsetY < scrollY.value && progress.value === 1) {
if (Platform.OS === 'android') {
// add header height to scrollY value to fix android bounce issue
scrollY.value = scrollY.value + headerHeight;
}
progress.value = withTiming(0, {
duration: 500,
});
}
scrollY.value = withTiming(offsetY);
});
const translateYStyle = useAnimatedStyle(() => {
return {
transform: [
{
translateY: interpolate(
progress.value,
[0, 1],
[0, -headerHeight - 10],
Extrapolate.CLAMP,
),
},
],
};
});
return {
translateYStyle,
scrollHandler,
};
}; So you can use it in the screen like this const headerHeight = 80; // Height of the header
const translateTheshold = 50; // Threshold to start the animation
const {translateYStyle, scrollHandler} = useTranslateHeaderOnScroll({
headerHeight,
translateTheshold,
}); |
@MDG-MMeksasi could you explain how your solution works? I'm having a hard time trying to understand |
I'm facing this same issue on RN 0.71.5 |
@jvfalco1 @caiopngoncalves did you try my solution? could you try it please just to see if it works properly |
@MDG-MMeksasi Yeah, It works. I just wanted to understand more about the problem |
Actually dont, because Im facing the same issue but Im not translating it, Im reducing the Height of the component. |
it should be better if you target translateY, otherwise, it should always be laggy on android |
@MDG-MMeksasi Even with translation I get the same error, Unfortunately I have to use the height. Unfortunately I think ill not be able to fix this |
Had the same issue that I've "fixed" following the upvote comment there. It has to do with interpolation ratio, seems like android doesn't like when dealing with decimals on that side... |
It blocks our apps release . Is there any update on this issue 🤔 |
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
+1 |
Any answer for this? It since 5 years and still don't see the solution |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
. |
Environment
React Native Environment Info:
System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 862.68 MB / 16.00 GB
Shell: 3.2.57 - /bin/sh
Binaries:
Node: 10.9.0 - ~/.nvm/versions/node/v10.9.0/bin/node
Yarn: 1.10.1 - ~/.nvm/versions/node/v10.9.0/bin/yarn
npm: 6.2.0 - ~/.nvm/versions/node/v10.9.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.2, macOS 10.13, tvOS 11.2, watchOS 4.2
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 9.2/9C40b - /usr/bin/xcodebuild
npmPackages:
react: 16.6.0-alpha.8af6728 => 16.6.0-alpha.8af6728
react-native: ^0.57.3 => 0.57.3
npmGlobalPackages:
react-native-cli: 2.0.1
Description
I'm trying to implement collapsible header using React Native Animated API. using event method i get AnimatedHeaderValue and interpolate it into translateY value.
This value i apply to container of my listView (so listView moves vertically).
IOS animation works perfectly, but Android animation jumping and lagging when i scroll. I tried to inscrease scroll value and Android animation became more smooth.
This is scrollView container that passes onScroll to scrollView (listView)
<ScCompanyNewsFeedList optimizeHeight getRef={scrollView => { console.log("SCROLL VIEW", scrollView) this._scrollView = scrollView; }} scrollEventThrottle = { 2 } onScroll={Animated.event( [{ nativeEvent: { contentOffset: { y: this.AnimatedHeaderValue }}}], )} companyId={this.props.companyId}/> }
this is base container that contains tabs and my scrollView. It's moving when scroll.
<Animated.View style={[{flex: 1}, {transform: [{translateY: headerHeight}]}]}> ... </Animated.View>
Interpolation
const animationRange = this.AnimatedHeaderValue.interpolate({ inputRange: [0, scrollRange], outputRange: [0, 1], extrapolate: "clamp" }); const headerHeight2 = animationRange.interpolate({ inputRange: [0, 1], outputRange: [0, -200] });
The text was updated successfully, but these errors were encountered: