Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for jumpy rendering of VirtualList with initialScrollIndex prop specified #18104

Closed
rbrosboel opened this issue Feb 26, 2018 · 3 comments
Closed
Labels
Resolution: PR Submitted A pull request with a fix has been provided. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@rbrosboel
Copy link
Contributor

rbrosboel commented Feb 26, 2018

Is this a bug report?

Yes. Pull request will follow.

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: Windows 10
Node: 8.9.4
Yarn: Not Found
npm: 4.6.1
Watchman: Not Found
Xcode: N/A
Android Studio: Version 3.0.0.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: https://github.com/expo/react-native/archive/sdk-25.0.0.tar.gz => 0.52.0

Steps to Reproduce

See snack: https://snack.expo.io/Sy_bHbM_z

  1. Render SectionList, with initialScrollIndex prop specified
  2. Watch how list items jump between first/second rendering

Expected Behavior

List items would render at a consistent position.

Actual Behavior

VirtualizedList with initialScrollIndex specified renders content in different positions for the first/second rendering, causing a noticable jump of the list items.

Reproducible Demo

https://snack.expo.io/Sy_bHbM_z

@rbrosboel
Copy link
Contributor Author

Pull request: #18105

@react-native-bot react-native-bot added Resolution: PR Submitted A pull request with a fix has been provided. Lists labels Mar 9, 2018
@react-native-bot react-native-bot added the Platform: Windows Building on Windows. label Mar 20, 2018
@hramos hramos removed the Platform: Windows Building on Windows. label Mar 29, 2018
@stale
Copy link

stale bot commented Jun 27, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 27, 2018
facebook-github-bot pushed a commit that referenced this issue Jul 20, 2018
Summary:
See #18104

Tested the above snack with:
- stickyHeadersEnabled true/false
- initialScrollIndex set and not

Visibly verified consistent rendering.

[GENERAL] [BUGFIX] [VirtualizedList] - Fix for jumpy content when initialScrollIndex specified
Pull Request resolved: #18105

Differential Revision: D8382122

Pulled By: sahrens

fbshipit-source-id: 9421351469e8684bc61438605abbd9988b664c29
@stale
Copy link

stale bot commented Jul 27, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jul 27, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Jul 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: PR Submitted A pull request with a fix has been provided. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

3 participants