Poor performance after updating to >= 0.50.0

[jslok]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: Windows 10
Node: 9.3.0
Yarn: 0.27.5
npm: 5.6.0
Watchman: Not Found
Xcode: N/A
Android Studio: Version 3.0.0.0 AI-171.4443003

Packages: (wanted => installed)
react: ^16.2.0 => 16.2.0
react-native: ^0.49.5 => 0.49.5

Steps to Reproduce

My app is currently on RN 0.49.5 and I would like to update to 0.52.0. After updating, the app has very poor performance on Android. Scrolling is very jittery, button presses lag, and low frame rate. I changed nothing except updating react-native version. This issue occurs when I try to update to any version >= 0.50.0. If I revert back to 0.49.5, the issue goes away. iOS works fine.

Any ideas would be much appreciated.

[1c7]

Can you provide more info about your app?

if it's on App Store, can you provide a download link?
just want get a idea about how complex your app are(how many screen? a lot image? long list?)
using ListView or FlatList?

Maybe it only have bad performance under development mode? (in Android simulator)

have you tried pack it up as .apk and install on your phone see if it get any better?

just trying to help, I am not a RN expert,

[jslok]

Yes I have a lot of screens, images, and long flatlists using redux and react-navigation. My code is the same when I try 0.49.5 vs. >= 0.50.0 though. The only change I make is the RN version and >=0.50.0 is laggy in production mode.

[joshjhargreaves]

@jslok any more information on this?

[jslok]

@joshyhargreaves I just tried with 0.53.0 and the issue still exists for me.

[joshjhargreaves]

@jslok how easy do you think this would be to reproduce with a demo project? Does it feel the same way with a newly initialised project? Are there any other factors you think could be affecting? A particular device?

[react-native-bot]

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

_{How to Contribute • What to Expect from Maintainers}

[joshjhargreaves]

@jslok what android version is the phone you're using on?
Our crash reporting started getting crashes on Android 4.x devices after upgrading from 0.45 to 0.53.
I've just spotted this commit: 4f886a2 which looks like it explains the new crashes. In relation to revert ing of this commit, the background UI thread had a bigger stack size limit for android 4.x and below, which explains why we started seeing stack overflow crashes when this increased limit was removed as per the removal of the background UI thread via this commit.

But anyway, it looks like more work could now be being done on the UI thread in your case perhaps, when it was not, before 0.51. What I could do for you is revert this commit, and push it to a branch with the build assets so you could update your package.json to see if this was the cause?

This issue is related: #16825

[jslok]

@joshyhargreaves Thanks for following up. Yes, I'd like to test with your branch and see if it was that. My device is on android 7.0.

[hramos]

Closing after a period of inactivity. Happy to reopen once more info is provided.