Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border color behaviour breaks in Android in 0.51 #17286

Closed
AndrewIngram opened this issue Dec 20, 2017 · 5 comments
Closed

Border color behaviour breaks in Android in 0.51 #17286

AndrewIngram opened this issue Dec 20, 2017 · 5 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@AndrewIngram
Copy link
Contributor

I've been using the old trick from CSS days to draw triangles with React Native, eg:

<View style={{
  width: 64,
  height: 64,
  borderWidth: 32,
  borderColor: 'red',
  borderTopColor: 'transparent',
  borderLeftColor: 'transparent',
 }} />

Expo Snack reproduction here: https://snack.expo.io/Skyt2nPzG (Switch between SDK 24 and 23 to toggle between React Native 0.51 and 0.50)

In React Native 0.50 and earlier, this correctly renders like this:
rn050

In React Native 0.51 it renders like this:
rn051

Explicitly defining border colors for all sides seems to be a workaround:

<View style={{
  width: 64,
  height: 64,
  borderWidth: 32,
  borderRightColor: 'red',
  borderBottomColor: 'red',
  borderTopColor: 'transparent',
  borderLeftColor: 'transparent',
 }} />

iOS behaves as expected in all versions.

@react-native-bot
Copy link
Collaborator

@facebook-github-bot no-template

@facebook-github-bot
Copy link
Contributor

Hey @AndrewIngram, thanks for posting this! It looks like your issue is missing some required information. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce your issue. I am going to close this, but please feel free to open a new issue with the additional information provided. Thanks!

How to ContributeWhat to Expect from Maintainers

@shergin
Copy link
Contributor

shergin commented Dec 24, 2017

cc @RSNara

@stale
Copy link

stale bot commented Feb 22, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 22, 2018
@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 5, 2018
@hramos hramos added the Android label Mar 8, 2018
@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 9, 2018
@react-native-bot react-native-bot added the Ran Commands One of our bots successfully processed a command. label Mar 17, 2018
@react-native-bot
Copy link
Collaborator

This issue was marked as lacking information required by the issue template. There has been no activity on this issue for a while, so I will go ahead and close it.

If you found this thread after encountering the same issue in the latest release, please feel free to create a new issue with up-to-date information by clicking here.

If you are the author of this issue and you believe this issue was closed in error (i.e. you have edited your issue to ensure it meets the template requirements), please let us know.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 17, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Mar 17, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants