Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onLayout in Flatlist item sometimes returns incorrect values #16782

Closed
elliscwc opened this issue Nov 10, 2017 · 1 comment
Closed

onLayout in Flatlist item sometimes returns incorrect values #16782

elliscwc opened this issue Nov 10, 2017 · 1 comment
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@elliscwc
Copy link

elliscwc commented Nov 10, 2017

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: Windows 10
Node: 8.1.3
Yarn: 0.27.5
npm: 4.6.1
react-native: 0.49.1
react: 16.0.0-beta.5
Target Platform: iOS and Android

Steps to Reproduce

I am using Flatlist with a very long list of array data, because the items have variable heights, scrolling from bottom to top of the long list will cause jumpiness (due to unmounting/mounting), so I use onLayout on the item view to calculate the height and then pass to the parent component so that every time the item is mounted again, it has the fixed height, thus fix the jumpiness, however the onLayout function does not always return the actual height on some items at the bottom of the list.

  1. Create a Flatlist with large amount of items
  2. Each item has the onLayout to calculate the height
  3. Set the height to the item

Expected Behavior

The onLayout should return the correct height so that the list shows correctly. To clarify, inside each of the item's child, it has to go through a few if-else statements to return what to render. My opinion in this is that it causes a race condition, where the onLayout calculation is called first before all the operation and rendering processes has complete, thereby giving wrong height value. The onLayout should wait for the rendering to complete only then it should do the layout calculation.

Actual Behavior

onLayout returns incorrect value.

@stale
Copy link

stale bot commented Jan 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 9, 2018
@stale stale bot closed this as completed Jan 16, 2018
@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

1 participant