You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Development Operating System: Mac OS Sierra 10.12.6
Build tools: iOS
Steps to Reproduce
(Write your steps here:)
react-native init TestProject
cd TestProject
react-native run-ios
Expected Behavior
It should run as the example in the docs.
I would like to ask that did you really test the release (with simple init command) before releasing? Yes I know RN is currently in heavy development but since 0.46 there are many breaking changes and init command is a fundamental feature, it shouldn't be ignored.
I also wondered about this. I remember that react-native test app is pretty decent (including the snapshot thing to check regression) but maybe it's no longer hooked to a continuous integration?
Yeah, we have quite a lot of tests to run - I am running them every time I am releasing new version (including 0.49.0-rc.0).
It's my fault that I've released 0.48.0 by promoting latest RC to stable. It's a mix of automation and routine that happened over the course of months. For context, every-time I am cherry-picking new commits, I always release a new version straight away and test it. That way, when I have to release stable and next release candidate, I test just the new version. This time, someone cherry-picked commits for me and didn't release a new version. My problem is that I assumed that version was already published (just like I do it) and automatically promoted it to stable. And commits in-between ended up being those breaking it.
I am going to go ahead and add appropriate notes to Releasing guide. Once again, apologies for all the inconvenience.
Is this a bug report?
Yes.
Have you read the Contributing Guidelines?
Yes.
Environment
react-native 0.48.0
node 8.4.0
npm 5.4.0
Then, specify:
Steps to Reproduce
(Write your steps here:)
react-native init TestProject
cd TestProject
react-native run-ios
Expected Behavior
It should run as the example in the docs.
I would like to ask that did you really test the release (with simple init command) before releasing? Yes I know RN is currently in heavy development but since 0.46 there are many breaking changes and
init
command is a fundamental feature, it shouldn't be ignored.Actual Behavior
Same with #15762
The text was updated successfully, but these errors were encountered: