Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was the release really tested? #15779

Closed
Doko-Demo-Doa opened this issue Sep 4, 2017 · 2 comments
Closed

Was the release really tested? #15779

Doko-Demo-Doa opened this issue Sep 4, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@Doko-Demo-Doa
Copy link

Doko-Demo-Doa commented Sep 4, 2017

Is this a bug report?

Yes.

Have you read the Contributing Guidelines?

Yes.

Environment

  1. react-native 0.48.0
  2. node 8.4.0
  3. npm 5.4.0
  4. `yarn 0.27.5

Then, specify:

  • Target Platform:
  • Development Operating System: Mac OS Sierra 10.12.6
  • Build tools: iOS

Steps to Reproduce

(Write your steps here:)

  1. react-native init TestProject
  2. cd TestProject
  3. react-native run-ios

Expected Behavior

It should run as the example in the docs.

I would like to ask that did you really test the release (with simple init command) before releasing? Yes I know RN is currently in heavy development but since 0.46 there are many breaking changes and init command is a fundamental feature, it shouldn't be ignored.

Actual Behavior

Same with #15762

@gre
Copy link
Contributor

gre commented Sep 4, 2017

I also wondered about this. I remember that react-native test app is pretty decent (including the snapshot thing to check regression) but maybe it's no longer hooked to a continuous integration?

@grabbou
Copy link
Contributor

grabbou commented Sep 4, 2017

Yeah, we have quite a lot of tests to run - I am running them every time I am releasing new version (including 0.49.0-rc.0).

It's my fault that I've released 0.48.0 by promoting latest RC to stable. It's a mix of automation and routine that happened over the course of months. For context, every-time I am cherry-picking new commits, I always release a new version straight away and test it. That way, when I have to release stable and next release candidate, I test just the new version. This time, someone cherry-picked commits for me and didn't release a new version. My problem is that I assumed that version was already published (just like I do it) and automatically promoted it to stable. And commits in-between ended up being those breaking it.

I am going to go ahead and add appropriate notes to Releasing guide. Once again, apologies for all the inconvenience.

@grabbou grabbou closed this as completed Sep 4, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Sep 4, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants