Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request #15098

Closed
sm2017 opened this issue Jul 19, 2017 · 2 comments
Closed

Feature request #15098

sm2017 opened this issue Jul 19, 2017 · 2 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. Type: Enhancement A new feature or enhancement of an existing feature.

Comments

@sm2017
Copy link
Contributor

sm2017 commented Jul 19, 2017

At first see #15046 (comment)

Here we have a base64 encoding in native environment and base64 decoding in js environment( and vise versa for sending binary)

This redundant encode/decode take a lot of CPU resources and can be omitted

In https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/bridge/WritableMap.java#L21 we only have putString so we cannot transfer binary from native to js or vise versa , I request void putByte(String key, Byte value); method for android and similar method for iOS and JS side

@charpeni
Copy link
Contributor

@facebook-github-bot feature

@facebook-github-bot
Copy link
Contributor

Hey @sm2017! Thanks for opening the issue, however it looks like a feature request. As noted in the Issue template we'd like to use the GitHub issues to track bugs only. Can you implement the feature as a standalone npm module? If not, consider sending a pull request or a creating an entry on Canny. It has a voting system and if the feature gets upvoted enough it might get implemented. Closing this now, thanks for understanding!

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Jul 19, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 19, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
@hramos hramos added the Type: Enhancement A new feature or enhancement of an existing feature. label Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

5 participants