Skip to content

Commit

Permalink
Fix missing emitter attributes on iOS TextInput when controlled compo…
Browse files Browse the repository at this point in the history
…nent value specified using `value` instead of `children` (#47269)

Summary:
Pull Request resolved: #47269

There were [reports](reactwg/react-native-releases#595) that patching in the fixes for iOS controlled input did not work as expected.

I think tracked this down to a difference in how I tested, where the controlled component I used passed value as a child of the `TextInput`, instead of via `value`. Passing via `value` triggers a secondary bug, where we don't correctly pass a reference to correct ShadowView when creating attributedstring, specifically in the iOS TextInputShadowNode impl.

We previously passed nothing for the ShadowView (only the first two struct fields). This was exposed in D52589303 which enabled `-Wextra`, but there, I went with same behavior of passing empty ShadowView, instead of the correct behavior (like Android impl) of passing a ShadowView of the current ShadowNode.

After fixing this, we now correctly create event emitters in the passed attributedstring, which matches expectations for pargraph-level eventemitter now in typing attributes. We don't seem actually use this on iOS for TextInput right now (just Text), but this is likely the right foundation for events regardless.

Changelog:
[iOS][Fixed] - Fix missing emitter attributes on iOS TextInput when controlled component value specified using `value` instead of `children`

Reviewed By: cipolleschi

Differential Revision: D65108163

fbshipit-source-id: 499fe28439fabd2579eca6ded7fd13fd8ea2e43e
  • Loading branch information
NickGerleman authored and blakef committed Nov 12, 2024
1 parent 40093d9 commit fbe38bb
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ AttributedString TextInputShadowNode::getAttributedString(
.string = getConcreteProps().text,
.textAttributes = textAttributes,
// TODO: Is this really meant to be by value?
.parentShadowView = ShadowView{}});
.parentShadowView = ShadowView(*this)});

auto attachments = Attachments{};
BaseTextShadowNode::buildAttributedString(
Expand All @@ -110,7 +110,8 @@ void TextInputShadowNode::updateStateIfNeeded(
(!state.layoutManager || state.layoutManager == textLayoutManager_) &&
"`StateData` refers to a different `TextLayoutManager`");

if (state.reactTreeAttributedString == reactTreeAttributedString &&
if (state.reactTreeAttributedString.isContentEqual(
reactTreeAttributedString) &&
state.layoutManager == textLayoutManager_) {
return;
}
Expand Down

0 comments on commit fbe38bb

Please sign in to comment.